Refined-github: Show status of PR in overview

Created on 15 Sep 2016 · 8Comments · Source: sindresorhus/refined-github

With the new PR review features GitHub introduced today, it's possible to "review" a PR. It is possible to approve the PR, or to request changes.

My problem is, that after I approve or request changes, I can't see in the overview what I've done. I need to click on every PR and check what the status is.

enhancement help wanted

Source

SpaceK33z

👍3

Most helpful comment

Looks like GitHub implemented exactly what I wanted:

pull_requests_ _webpack_webpack_js_org

If you hover over them you see more details. Super awesome! Closing this.

SpaceK33z on 22 Nov 2016

🎉2

All 8 comments

What kind of status are you interested in? Like Approved, Pending requested changes, etc?

sindresorhus on 16 Sep 2016

Yeah, those two statuses.

SpaceK33z on 16 Sep 2016

Seems like many people agree: https://twitter.com/dan_abramov/status/777224519543128064

Anyone wanna do a pull request?

sindresorhus on 17 Sep 2016

I like the idea a lot, but this is could be brutal for people on slow connections if we don't offer a setting to disable. We'll have to make (up to) 25 requests on page load anytime you visit /pulls/. The GitHub API doesn't have the ability to batch requests (and the new GraphQL API doesn't have the functionality we'd need quite yet), so we'd just be fetching the DOM for each PR page

DrewML on 18 Sep 2016

@DrewML, is it correct that the GitHub API doesn't even have the ability to see the status at all? I've browsed through it, but the "review comments" API also doesn't seem to have it.

SpaceK33z on 18 Sep 2016

@SpaceK33z Yeah, doesn't look like it :( We'd have to do fetch + DOM parsing/scraping like we do with real names functionality.

DrewML on 19 Sep 2016

While these reviews could prove to be immensely useful I think they are in very early stage at the moment and GitHub would significantly improve them in the next 6 months (as stated at GitHub Universe). They could fix some nagging problems in the review process, but could also improve the API and the rest of the UI around them. I'm not sure this is worth doing before we see what they'll do with them. I guess we could contact GitHub and urge them to add the review status to the PR list. I'd also like to add them to the search filters.