Refined-github: Fix reaction avatars with new GitHub changes

[hkdobrev]

GitHub has added Oxford comma to the tooltip for Emoji reactions and more text to the end of it. We'd need to adjust the way we extract usernames from the tooltip.

Example: https://github.com/composer/composer/pull/5174#issuecomment-209524734

The tooltip used to say:

hkdobrev, nikolas-grekas and Nikofuma

Now it says:

hkdobrev, nikolas-grekas, and Nikofuma reacted with +1 emoji

Expected result:
We should extract the correct usernames and show avatara for "hkdobrev", "nikolas-grekas" and "Nikofuma".

Actual result:
We show avatars for "hkdobrev", "nikolas-grekas" and "Nicofuma reacted with +1 emoji" which results in a broken image. The problem is reproducible when there are maximum of 3 people reacted.

[DrewML]

Interesting - I'm seeing the Oxford comma, but not the extra text or breakage.

[hkdobrev]

@DrewML Try on a comment with 3 people reacted and you're one of them.

[hkdobrev]

@DrewML OK, it seems they've fixed it back actually. On the same comment, I'm now seeing what you're seeing. It could have been something they've reverted quickly. If you look closely at the message above you'd see it said "reacted with +1 emoji" when people were reacting with the tada emoji 🎉 . So they might have reverted the the change partially to fix it or drop the copy altogether.

I'll close this and we can reopen if they change it back.

[DrewML]

Hahaha, @hkdobrev, I went to go react to your reply, and then this happened

[DrewML]

@sindresorhus Did this ever get pushed to the Chrome store? I just installed this from the Chrome store on a new machine (I normally use the copy from master) and avatars are broken in a similar way.

[paulmolluzzo]

@DrewML unless @sindresorhus manually pushed it, no. There hasn't been an automated since we only whitelisted tag branches as of #182 and that hasn't been pushed. Really, if someone just wants to make a v1.0.3 tag and push that to master it should deploy. We have #189 in master so that's a good reason to deploy on its own.

[sindresorhus]

Yeah, go ahead. Hopefully it will work now :)

[paulmolluzzo]

Just pushed 1.0.3

[paulmolluzzo]

😞 https://travis-ci.org/sindresorhus/refined-github/builds/126706051

I'm pushing a fix directly on master. It's not worth all the trouble. I am pretty sure it's the camelCase task name.

[paulmolluzzo]

https://travis-ci.org/sindresorhus/refined-github/builds/126708620 🎆

It probably takes a bit to be publicly visible, but the build passed entirely and looks like it deployed.