Redwood: Rename 'diagnostics' to 'check'

Created on 11 Aug 2020  路  9Comments  路  Source: redwoodjs/redwood

Hey Aldo,

Had a suggestion from @schickling that diagnostics is a rather difficult command to spell, and I agree, he made a suggestion to rename it "doctor" which I really like, thoughts?

An example of this is brew doctor.

TODO

  • [ ] Alias diagnostics command to check.
good first issue cli

Most helpful comment

What about check or verify?

All 9 comments

I'd prefer to keep diagnostics and alias to something like diag or (I haven't checked namespace if possible) even just d.

What about check or verify?

diag or (I haven't checked namespace if possible) even just d.

d is already used as an alias for destroy

Given the destructive nature of destroy we should consider aliasing it to something like rm instead of d.

I like that it's so easy to remember the aliases used by the rw cli, so I'd prefer to keep it as d. But I agree that it's very destructive. How about a confirmation step? "Are you sure you want to delete the ? This can not be undone."

I'd love to PR the confirmation if that's something you'd want. Should be easy to get going with https://www.npmjs.com/package/yargs-interactive

@Tobbe I don't really find d to be an immediately obvious a choice for destroy, but for this issue it looks like we're going to either rename the command to check or alias it to check.

I like check.
Specially if we extend it to include not only the diagnostics from redwoodjs/structure, but also TSC errors, prisma errors, etc.
See this comment for a longer explanation (https://github.com/redwoodjs/redwood/issues/970#issuecomment-677794325)

Closed by #351

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jeliasson picture jeliasson  路  3Comments

aldonline picture aldonline  路  3Comments

peterp picture peterp  路  4Comments

slavakurilyak picture slavakurilyak  路  4Comments

josteph picture josteph  路  3Comments