Redux: Stop using babel-eslint

[gaearon]

It is not necessary anymore.
We should migrate our source and examples to not use it.

[raspo]

wrong link? https://twitter.com/geteslint/status/714642903482564608

[gaearon]

Lol yeah, that’s the one.

[kennetpostigo]

@gaearon how come it is not needed anymore?

[gaearon]

From https://twitter.com/geteslint/status/714642903482564608:

The ESLint default parser natively supports ES2016, JSX, and object rest/spread. You don't need babel-eslint for any of that.

[kennetpostigo]

Awesome!
thank you @gaearon

[michaelwilcox]

@gaearon would this require an update to the eslint-config-rackt dependency? I couldn't find the repository hosted anywhere on GitHub. Looking at the installed eslint-config-rackt package though, I do see "parser": "babel-eslint", in index.js.

[knowbody]

I'm working on this one, updating the rackt config to airbnb as this was requested somewhere already anyway, and eslint-config-rackt is not mainatined

[gaearon]

Yea.

[knowbody]

@gaearon do you have any preference for customizing eslint-config-airbnb? or just follow it as is? I will push WIP soon

[gaearon]

What about semicolons? I couldn't care less about whether we use them or not but I'm concerned about the amount of work it would take to convert docs back. On the other hand any changes to style would require tweaking docs anyway.

Can we just use eslint --fix and write a script to run Markdown embedded snippets through it as well?

[knowbody]

what about stuff like: vars-on-top, no-param-reassign?

[gaearon]

Ugh. I guess we'll have to use a custom config. vars-on-top doesn't make sense to me.

[knowbody]

same here. I would just make both of those disabled then. also I used eslint --fix before and it fixed semicolons.

[knowbody]

@gaearon these (https://gist.github.com/knowbody/6a59ddbc1bbff7bfa43c731ca531d1b3) are all after the --fix let me know which ones should we exclude

[gaearon]

Thank goodness. What do you think about a script that --fixes docs? Could be useful to other libs too.

[knowbody]

I can hack something

[knowbody]

but have a look at this https://github.com/eslint/eslint-plugin-markdown
I'll check if that works once I get home, on my phone now

[gaearon]

Apart from vars-on-top, these look sensible to me.
We should also switch to using const (with let where needed).

[knowbody]

Cool will send the PR soon

[gaearon]

Ideally we should merge some hanging PRs before merging that. I haven’t had time to do that yet.

[knowbody]

@gaearon what about react/prefer-stateless-function? this specifically touches the examples.

Ideally we should merge some hanging PRs before merging that. I haven’t had time to do that yet.

that's totally fine, I will make a WIP PR and we can update it once you have whatever you need merged

[gaearon]

I’m good with using stateless functional components where possible

[nickuraltsev]

I submitted a PR that updates most of the examples to use functional
components several days ago.

On Wednesday, March 30, 2016, Dan Abramov [email protected] wrote:

I’m good with using stateless functional components where possible

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/reactjs/redux/issues/1554#issuecomment-203700218

[knowbody]

oh, shame I didn't have a look... just pushed that change to my PR. But it doesn't matter, as @gaearon said we will probably merge some PRs before merging mine. So yours should be merged, thanks for your work @nickuraltsev !

[nickuraltsev]

You are welcome!

[guidsen]

What is the status of this issue? Any help needed?

[timdorr]

Since we're using eslint-config-react-app, it requires it as a peer dependency. If they drop using it in the future, we can do so here. For now, we're "stuck" using it (which is fine).