Redux: Update TodoMVC example to be more in line with other examples

[gaearon]

This is up for grabs.

TodoMVC hasn’t received much love over the last few months. We should update it to store visibilityFilter in the state, split it into presentational and container components, and update the reducer code to use composition.

It might even be easier to take the new vanilla todos example and tweak it until it looks and acts as TodoMVC. Bonus: add Reselect into it as described in “Computing Derived Data”!

If you want to do it, please write in this thread!

[juliannovy]

I'd love to contribute.

[montogeek]

I can contribute!

[gaearon]

Cool, @julianusti grabbed the task first.

@julianusti Please post your work in progress in a PR as it goes so we can discuss the work as it happens. If you feel like you don’t have time to finish it let us know so others can pick it up.

Thanks!

[juliannovy]

@gaearon cool, thx.

[jontewks]

@julianusti is this underway? I would also like to contribute but there aren't many help wanted tags available.

[urbanvikingr]

@jontewks If you like, I am looking for someone to pair with on adding tests to todos example. I would like to have some container and component tests added. Mocha has been used the other tests, and I am open to Jasmine and/or Jest. I'll create a new issue for this.

[juliannovy]

@jontewks hey, I've started but haven't chance to accomplish it yet. I would do my best to do it the next two-three days, otherwise I'll let u know and u can pick it up.

[gaearon]

Ping :wink:

[montogeek]

I can ping too to help ;) ;)

[gaearon]

@julianusti Let us know if you’re busy. If you are, @montogeek can pick it up.

[juliannovy]

@gaearon @montogeek hey guys, sorry for late respons, haven't chance to finish it yet, so, please @montogeek pick it up.

[montogeek]

I will work on it today :)

[michaelwilcox]

I gave this a try here #1480

[Huanzhang89]

is this still up for grabs? Saw quite a few people already saying they are working on it

[timdorr]

Go for it! :)

[Huanzhang89]

Thanks @timdorr will have a crack at it today.

@gaearon could you elaborate a bit on the Computing Derived Data part please?

[tomipaul]

@gaearon @timdorr @Huanzhang89 Is this still open? I would like to work on it

[timdorr]

Yes, it's open for anyone to take on. Otherwise the issue would be closed :)

[tomipaul]

Thanks @timdorr I will take on the task

[tomipaul]

Hi @timdorr I attempted this here #2757
I would love feedback if there's any

[phsantiago]

@timdorr, still up to grab or @tomipaul solved that?

[timdorr]

It looks like there's a PR open, but if you want to make your own or build on theirs, go right ahead. It's whatever code is best, not first.

[JosephMart]

Is this still yet to be completed or just not closed?

[timdorr]

There is #2757 open for it.

[JoeDuncko]

https://github.com/reactjs/redux/pull/2757 seems to be merged. Should this be closed?

[timdorr]

Yup!