Redux-devtools: react-redux 1.0.1 and react 0.14.0-beta3

Created on 27 Aug 2015 · 12Comments · Source: reduxjs/redux-devtools

devtools causes a bunch of warnings:

Warning: Failed propType: Invalid propchildrensupplied toProvider, expected a single ReactElement. Check the render method ofDevToolsWrapper.

With React 0.14 and later versions, you no longer need to wrap <Provider> child into a function.

Warning:require("react").findDOMNodeis deprecated. Please userequire("react-dom").findDOMNodeinstead.

I think the first ones are just adjustments to the 1.0 release of react-redux.

for the last one it would be nice if devtools could have support for both react 0.13 and 0.14, is that doable and desirable?

Source

janusch

Most helpful comment

@eriknyk

Change

<Provider>
  {() => <Stuff />}
</Provider>

<Provider>
  <Stuff />
</Provider>

Note that this question is unrelated to this repo.

gaearon on 7 Oct 2015

👍10 😄5 🎉2

All 12 comments

I think you should report this to gaearon/react-redux repo instead since redux nor redux-devtools have no dependency or requirement on React version.

Either way, I haven't tried 0.14 yet, but I am wondering if react-dom package can be used with 0.13. That would make transition very easy.

FredyC on 27 Aug 2015

I think you should report this to gaearon/react-redux repo instead since redux nor redux-devtools have no dependency or requirement on React version.

No, this is the right place. We're using findDOMNode in LogMonitor.
We should really split LogMonitor into a separate project: #61. Then it'll be easier to version it.

if react-dom package can be used with 0.13. That would make transition very easy.

It can't.

gaearon on 27 Aug 2015

Just a short update:
the first two warnings are gone in redux-devtools 2.0; great!

´Warning: require("react").findDOMNode is deprecated. Please use require("react-dom").findDOMNode instead´ - is still pending.

janusch on 2 Sep 2015

The last warning will go away when we switch to React 0.14, which will happen when it comes out.

gaearon on 3 Sep 2015

how can be fixed the warning:

With React 0.14 and later versions, you no longer need to wrap child into a function.

Regards.

eriknyk on 7 Oct 2015

@eriknyk

Change

<Provider>
  {() => <Stuff />}
</Provider>

<Provider>
  <Stuff />
</Provider>

Note that this question is unrelated to this repo.

gaearon on 7 Oct 2015

👍10 😄5 🎉2

@gaearon googling led me to your solution - thanks as this problem was very irritating!

chrisfinch on 20 Oct 2015

:+1: was working off some of my previous redux code and ran into this.

MadLittleMods on 26 Oct 2015

@gaearon, thanks for your solution!

mastertinner on 28 Dec 2015

No problem. We only shipped the old API because we waited for React to support parent-based context. The new API was how we wanted it to be from the day one, and once 0.14 shipped, we switched it.

gaearon on 28 Dec 2015

I just only want to say big thanks to @gaearon. I had this problem, googled, find this, fix, done and only spent 1 minute. Awesome.