Redoc: False positive recursion

[krystof-k]

Hello there, wrestling following issue.

Imagine I want to reuse some schema, let's say ID – I have following in ./helpers/id.yaml:

properties:
  id:
    type: number
required:
  - id

And here is a simple OpenAPI, which should result in a simple structure of three nested objects, which all wants to reference the id helper.

openapi: 3.0.0
info:
  title: False positive recursion
  version: '3.0'
paths:
  /documents:
    get:
      summary: Example
      responses:
        '200':
          description: OK
          content:
            application/json:
              schema:
                allOf:
                  - $ref: ./helpers/id.yaml
                  - properties:
                      second:
                        allOf:
                          - $ref: ./helpers/id.yaml
                          - properties:
                              third:
                                allOf:
                                  - $ref: ./helpers/id.yaml
                                  - properties:
                                      something:
                                        type: string

Whereas the first and second object are correctly rendered with required id attribute, the third object is flagged as recursive:

Any idea? Is it a bug or am I missing something?

[RomanHotsiy]

It is a bug. I will investigate it when I have time

[StephaneLambert]

I had the same problem with a string property. It seems to appear with the use of allOf and basic types (integer, string, ...) simultaneously.
In this case, the components/schemas/ seems to be replaced by the basic type and result of a false recursion in Redoc.

[m-mohr]

I have the same issue and can provide another reproduction example, if required.

[remnestal]

Any news on how this issue is progressing? I could also provide additional examples if needed.

@jlaw90 looks like you may have a solution to the problem in https://github.com/jlaw90/redoc/commit/5f23b7add1e42a9cd9131413b7426697c64a8bf8, is this something you're planning to make a PR proposal for anytime soon? Would be greatly appreciated 🎉

[jlaw90]

@remnestal I just rebased the commit from #1186 to see if it fixed the problem for us but it didn't - I haven't had time to investigate further unfortunately

[agustin-tecso]

I have the same problem, I created the issue #1439.

[remnestal]

Looks like this might not be a problem anymore with the latest version of redoc-cli 🤷

[agustin-tecso]

Looks like this might not be a problem anymore with the latest version of redoc-cli shrug

I tried it whith the latest version 0.10.1 and there is still the problem