Redash: "Fork Query" is disabled outside of "View Source" mode

[susodapop]

Issue Summary

See screenshots. When viewing a query the fork link is disabled unless a user enters "View Source" mode.

Disabled

Enabled

Steps to Reproduce

1. Visit any query
2. Click the ⋮ button to observe the fork option is disabled.
3. Click Edit Source
4. Click the ⋮ button to observe that the fork option is now enabled

This is a regression from V8.

Technical details:

• Redash Version: v9 Alpha
• Browser/OS: Safari / MacOS
• How did you install Redash: SaaS / Preview Instance

[kravets-levko]

@susodapop I cannot reproduce this on master (at least on my local setup and on preview instance). Can you please share a link to the query with this issue (if possible), or check query and its datasource options?

[arikfr]

Levko, were you trying with an admin user? It happens only to non admins.

Arik

On Wed, May 27, 2020 at 4:39 PM, Levko Kravets < [email protected] > wrote:

@ susodapop ( https://github.com/susodapop ) I cannot reproduce this on
master (at least on my local setup and on preview instance). Can you
please share a link to the query with this issue (if possible), or check
query and its datasource options?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub (
https://github.com/getredash/redash/issues/4923#issuecomment-634667790 ) ,
or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AAAROLA3JX7H4VX5RPYARL3RTUJZ7ANCNFSM4NMD7PBQ
).

[susodapop]

@arikfr Is right. To reproduce it on the preview instance, log in as John Smith and visit any query.

[kravets-levko]

Confirmed. @arikfr Why can user list data sources, but cannot get even a minimum amount of info about particular one? This issue happens because to enable Fork button we need to know if query's data source is view_only or not. On source page we load all data sources anyway, so there we get DS from the list. On view query page we load DS directly, and API endpoint returns 403

[arikfr]

@kravets-levko the main reason is that there was no need for such API for non admins, so it was never implemented :)

[kravets-levko]

@arikfr Nevermind :slightly_smiling_face: That was a first question that crossed my mind, but later I thouht about it more and concluded that it should stay as is, because changing that API may introduce new bugs.