Redash: Enabling or disabling "Use Dashboard Level Filters" cause widgets to show reload spinner forever

[justinclift]

Issue Summary

When the "Use Dashboard Level Filters" checkbox is turned on, or turned off, the widgets in the dashboard then appear to attempt reloading, showing their spinner.

Unfortunately, this never finishes, with the spinner just keeping going... forever.

Steps to Reproduce

1. Create a new dashboard, adding any widget, then save it (Apply Changes).
2. Edit the widget, then enable "Use Dashboard Level Filters". The bug happens here.

Interestingly, going to another screen and coming back works. The dashboard appears fine, with the widgets loaded.

Even saving the new "enabled" state of the dashboard (when the widgets are still spinning), then coming back to it doesn't appear to have hurt anything. The dashboard loads fine, with the widgets showing ok.

The problem appears to be solely something to do with the widget reloading when the checkbox is changed.

Technical details:

• Redash Version: 7.0.0+b18042 (4a978bad)
• Browser/OS: 67.0.4 (64-bit), and Firefox 60.7.0esr (64-bit), both on CentOS 7
• How did you install Redash: via Docker in a local VM

[ranbena]

10x @justinclift!
Does this repro on master tho? The dashboard has undergone profound changes since v7.

(You can always test master on our Netlify Preview https://redash-preview.netlify.com)

[justinclift]

Thanks that Netlify instance saves time. :smile:

Yep, the bug seems present there as well:

[ranbena]

I tested on some earlier previews and it repro'd on all (stopped at Jan '19).
So either it's a backend issue, or a long running frontend bug.

@arikfr @kravets-levko any insights?

[kravets-levko]

@ranbena This is definitely a bug. I'll take it

[justinclift]

Looks good. The bug is no longer present when testing it on the Netlify Preview instance. :smile: