Redash: Query Editor view port occasionally panics in Firefox/Chrome

[susodapop]

Issue Summary

Under certain circumstances, the view area in my query editor shrinks to just a few lines. See the attached gif.

Steps to Reproduce

I'm not able to reliably reproduce this bug. But I've stopped using Firefox because it happens frequently enough. I can resolve the issue by resizing the browser window.

Technical details:

• Redash Version: 431d6fa
• Browser/OS: Firefox Quantum
• How did you install Redash: Skas

[arikfr]

@jezdez has anyone of your users or on your team experienced something like this with recent versions?

[jezdez]

Yep, it was filed a few days ago: https://github.com/mozilla/redash/issues/788 It hasn't been diagnosed yet, but it can be worked around by resizing. I'm not sure if the OP of the ticker is correct that this has been happening for months to be honest. Any help investigating this is appreciated.

[ranbena]

@jezdez @susodapop what OS is this happening on?

[susodapop]

MacOS 10.14.2

[arikfr]

@kravets-levko couldn't reproduce it on Linux.

Btw, Firefox 65 was released today. Worth checking if it was magically resolved in the new version :)

[manikanta-talanki]

Have the same issue

Technical details:
Redash Version: Redash 6.0.0+b8537 (4780bd9c)
Browser/OS: Chrome Version 72.0.3626.81 (Official Build) beta
How did you install Redash: Official docker image.

[ranbena]

@manikanta-talanki this happens to you in Chrome? What OS?

[jezdez]

@chrismore in https://github.com/mozilla/redash/issues/788:

I also want to note that this is a Firefox-only bug. I do not experience this within Chrome. It could be related to scroll anchoring: bugzilla.mozilla.org/show_bug.cgi?id=1519644

[dmackie]

Same issue in Chrome on Mac OS.

We just updated to v6 from v5 yesterday.

Technical details:

• Redash Version: 6.0.0.b8537
• Browser/OS: Chrome Version 72.0.3626.96 (Official Build) (64-bit)
• How did you install Redash: Docker

[kravets-levko]

@jezdez @susodapop or anyone who can reproduce this: I think the issue is somewhere on the edge between Angular and React code; maybe, editor's container component (which is Angular) has a different size when editor is rendered, and later become larger. Possible workaround is to call editor.resize() in componentDidUpdate() (also - not sure if it's a right place, but probably yes). Can anyone thy this and provide a feedback?

[jezdez]

Oh interesting to see this happens in Chrome as well since I was just about to let you know that we think (https://github.com/mozilla/redash/issues/788) that this has been fixed in Firefox 65. I can't reproduce it in Firefox anymore but can in Chrome.

@kravets-levko Trying out the resize thing in componentDidUpdate()..

[kravets-levko]

If it will not help - there is another workaround that will work for sure, but I'd like to use it only as a last resort.

[jezdez]

@kravets-levko That did the trick! See #3412. Thank you <3

[kravets-levko]

If anyone will encounter this bug in future - feel free to reopen this issue (but check that you Redash contains previous fix). Thanks!