Rector: [Bug] ImportFullyQualifiedNamesRector does not fix all FQCNs

[mxr576]

Because ImportFullyQualifiedNamesRector rector only checks files that have namespaced defined it it does not fix FQCNs in a procedural code like this.

<?php

function foo() {
    $baz = \Foo\Bar::Baz;
}
-----
<?php

use Foo\Bar;

function foo() {
    $baz = Bar::BAZ;
}

[TomasVotruba]

Indeed. Care to send PR?

[mxr576]

Not sure yet about the best solution for this problem, do you have an idea how this could be fixed?

[TomasVotruba]

Do 1 path for namespace and one without (this already exists).

[TomasVotruba]

Here is the exactly same issue just for different rule: https://github.com/rectorphp/rector/issues/1422

[TomasVotruba]

This will be more complicated, since it's not easy to add nodes without namespace above them.

I'll investigate

[mxr576]

Yeah, I bumped into to this problem before this was the reason why I asked your opinion about this :)

[TomasVotruba]

Sure :)

It will require adding new layer in Rector, that will work even with arrays of stmts, not just Node of type. I postponed this for a long time, because it's really not easy to solve.

[TomasVotruba]

It was a "bit" complicated, but it's done :rocket:

I've merged it to master. Could you test it on your code base?

[mxr576]

Awesome! 👍 This was a busy week, I'll try to check it in the weekend or early next week.

[mxr576]

Well, took more time as I expected... but now I am here. Testing it now :)