Rector: Update to php-parser 4.0.1 with new builder methods

Created on 26 Mar 2018  路  7Comments  路  Source: rectorphp/rector

All 7 comments

@TomasVotruba I'll do it tonight. We'll have to deal with composer require section as #330 wasn't finish yet, but should be easy :smile:

I thought you'd like it :+1:

It doesn't depend necessarily, this should be enough:

    "nikic/php-parser": "v4.0.1 as 4.0.x-dev"

Any updates on this?

Gonna push these changes tonight

@TomasVotruba The idea is to remove some methods from NodeFactory and use BuilderFactory as a dependency?

Yes, delegate code we don't need to maintain

@TomasVotruba Perfect, I'll code it :man_technologist:

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Aerendir picture Aerendir  路  5Comments

pavarnos picture pavarnos  路  4Comments

DaveLiddament picture DaveLiddament  路  5Comments

lstrojny picture lstrojny  路  4Comments

jakzal picture jakzal  路  4Comments