Recompose: Use webpack's side-effects flag to enable tree shaking in Webpack 4

[ConneXNL]

This library is missing the "sideEffects" : false in the package.json to enable Webpack 4 tree shaking.

Lodash-es example:
https://github.com/lodash/lodash/blob/master/package.json#L10

This would be a (better) alternative for:
https://github.com/acdlite/recompose#using-babel-plugin-lodash

[wuct]

Thanks for bringing this up!

[TrySound]

This is not relevant anymore
https://github.com/acdlite/recompose/blob/master/.size-snapshot.json#L17-L18

[billyjanitsch]

@TrySound why is it not relevant anymore? I realize that webpack can already tree-shake this package to some extent (thanks to your work! 😊) but can't adding sideEffects: false only help further?

[billyjanitsch]

Also, I notice that .size-snapshot.json never actually gets updated as e.g. a pre-commit hook, so the version in master corresponds to the snapshot when you made the initial rollup snapshot commit, despite changes that clearly affect bundle size and possibly tree-shaking having landed since then.

What is the mechanism by which you'd expect the snapshot to update? What's the purpose of having it in the repo?

[TrySound]

It's usually should be updated by users. But there is also matchSnapshot option which will fail in ci.

[TrySound]

Done https://github.com/acdlite/recompose/pull/672