Recompose: Breaking changes in 0.23.2/0.23.3

[reidblomquist]

Initial findings on our end are showing that 0.23.2/0.23.3 includes breaking changes - per https://github.com/callemall/material-ui/issues/6848

looks like this should've at least been a minor version and not a patch.

[istarkov]

0.23.2 was broken because of my mistake at release step.
0.23.3 must work and as I think does not contain breaking changes. Could you provide specific details what is broken?

[miksansegundo]

Hey, here is my breaking issue: createHelper.js is missing in v0.23.3

ERROR in ./~/material-ui/styles/withStyles.js
Module not found: Error: Can't resolve 'recompose/createHelper'

ERROR in ./~/material-ui/internal/withSwitchLabel.js
Module not found: Error: Can't resolve 'recompose/createHelper'

Related with https://github.com/acdlite/recompose/issues/66

[TrySound]

@miksansegundo Heh. I removed it. It wasn't documented. And it's not so useful. It breaks tree shaking.

[miksansegundo]

Material-UI use it. I will open an issue there.

On Fri, May 12, 2017, 12:38 PM Bogdan Chadkin [e-mail]
wrote:

@miksansegundo https://github.com/miksansegundo Heh. I removed it. It
wasn't documented. And it's not so useful. It breaks tree shaking.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/acdlite/recompose/issues/380#issuecomment-300988364,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABy1iaYcTujjIcvzllWQPRQSwtmNscKTks5r4_BFgaJpZM4NYmB-
.

[xDae]

+1 i used to use recompose for my components, now my boss made me remove from everywhere 😥

[travi]

for those tracking this, the material-ui issue is here: https://github.com/callemall/material-ui/issues/6849

[aacotroneo]

Related: recompose/pure stopped working in the material-ui icons (that use that function) when you build react for production! It simply returns a bad wrapped object.
Either compiling in dev mode or downgrading the version fixed my issue.

[aacotroneo]

https://github.com/acdlite/recompose/commit/a0a72bfcbc6988e70b0f3a60bb150a2a7fba8917#diff-a1e3850a92625b20984c44531204b27eR16 ?? I don't know the library.. but shouldn't wrap the component somehow for 'production' case as well?

[TrySound]

@aacotroneo which object?

[TrySound]

Damn, he is right, @istarkov. I skipped that. We need to call hoc with basecomponent, also we need to test production code.))

[reidblomquist]

Sorry I didn't provide more info in the initial report - was in react mode and had to slap version overrides into one of our packages that a few projects depend on, then respin a bunch of servers. Thanks for filling in the gaps everyone!

[istarkov]

0.23.4 pure fixed, please check

[miksansegundo]

@istarkov thanks. I will check asap.

[aacotroneo]

yay! my use case is working fine now!! (basically material ui icons with NODE_ENV='production' which use pure themselves). Thanks!

[jeremyadavis]

Fixes my issue with material-ui icons as well.

[pbassut]

What about recompose-relay? Looks like it broke that too.

I mean, a new npm package wasn't published

[istarkov]

Looks like broke or broke?

[pbassut]

Well, at least the latest published npm package is breaking because it's still using the createHelper function. And it's version requirements isn't strictly using [email protected]

[istarkov]

You are right, thank you!

[jkettmann]

Is there any time to expect an update of the recompose-relay npm package? The newest one is 0.3.1 and still uses createHelper