Recompose: Should pure use the new PureComponent?

[kevinSuttle]

https://github.com/facebook/react/pull/7730

[istarkov]

As I understand It will lock recompose on specific React version.
For now I use it in a big project with old React 0.14.x and it works well.
BTW Im not sure about React version support politic.
Sometimes it will be easier to drop old versions support but it will be a problem
for me if sometimes is today :-)

[wuct]

PureComponent checks both props and state. In contrast, pure checks only props, so it might be quicker.

[dlebedynskyi]

I think pure should stay as it is. First due to what @wuct sad.
2nd - pure is HOC, while PureComponent is full Component that you most likely going to use as class My extends React.PureComponent. To me this a bit different scenario of usage.
Unless PureComponent has some dramatic advantages in usage it does not make sense for me to deprecate or rework pure

[istarkov]

@dlebedynskyi pure HOC could be rewritten to use React.PureComponent and will have a really short source, so 2 is not so different ;-)

[dlebedynskyi]

@istarkov well yeah. But why does it has to be rewritten? it is not like is working wrong now.

[istarkov]

For fun for example, a good reason as I know ;-)

[dlebedynskyi]

@istarkov it is your repo guys) go for it if you really think it is needed )

[wuct]

I am going to close this issue because it's no longer active. Please feel free to reopen it if you have further input.