Reason: Rename refmt to refmt.exe

[chenglou]

From @bobzhang

in case we support windows later on.

I've forgotten how node works on windows. Do all the npm binaries that don't add .exe not work on windows?

@jordwalke @yunxing @tekknolagi

[yunxing]

Don't know much about how node works, maybe we can also create a symlink?

[tekknolagi]

I don't know anything about Node or Windows :-/

[OvermindDL1]

I've forgotten how node works on windows. Do all the npm binaries that don't add .exe not work on windows?

Or they make a bouncer .bat file that redirects to the exe version... Yes Windows is a pain...

EDIT:

Don't know much about how node works, maybe we can also create a symlink?

No symlinks on Windows without admin.

[jordwalke]

No symlinks on Windows without admin.

@OvermindDL1 I believe that windows can pretty reliably perform symlinks to directories, but not individual files, is this correct?

[OvermindDL1]

@OvermindDL1 I believe that windows can pretty reliably perform symlinks to directories, but not individual files, is this correct?

On Windows Vista and higher symlinks between directories should be reliable. Pre-vista they were not.
On Windows at least 10 (unsure of early, maybe back to 7) file symlinks should be reliable.

However, to do symlinks you either have to be the Guest user, or an Admin user.
Yep you read that right, you have to be the 'Guest' account or launch the program with "Administrative Privileges". The reasoning is that Guest is locked down enough they cannot symlink to anything they cannot see anyway, but normal users can symlink to anything, bypassing certain security aspects on the system. Yes it is stupid. ;-)

EDIT: You 'could' tell Windows to give you admin when you want to create a symlink though, the user will get the popup security box allowing it, which you can fall back to copying without it or so?

[bobzhang]

symlink does not work across drivers though

[OvermindDL1]

symlink does not work across drivers though

There are cases where it can (only on Windows 10 I think), but true in the general case yeah.

[chenglou]

The nit is that people have asked whether foo.exe is a windows binary before. Maybe it should be refmt.exe, and on the unix side we link refmt to it for convenience or something

[jaredly]

bucklescript supports windows at this point, I think we're done?