Reason: Better priority for object/record keys

Created on 26 Aug 2016 · 6Comments · Source: reasonml/reason

// This errors:
type foo = {open: false};
// another:
bla.open;

In general, it'd be great if record/obj keys have "higher priority" than build-in keywords? Is that a good idea? If not, at least better errors.

Source

chenglou

👍1

Most helpful comment

might be useful for external JS objects too. it's not uncommon to have "type" as a property name, and jsObj##type throws, forcing to create a FFI

bloodyowl on 11 Oct 2017

👍2

All 6 comments

I think this is doable even if a bit tricky. You have to create a new parse rule for identifiers suitable for use in places such as keys/record labels. Those identifiers would be the union of typical identifiers, and other tokens. We'd then just need to make sure that the compiler itself doesn't complain when handed an AST with record labels matching certain tokens - and if so, we'd have to do some escaping.

jordwalke on 26 Aug 2016

I think that's probably not a great idea? keywords should be keywords.
but let's ditch open from the default reason syntax :D (we can just have it be import * from SomeMod)