Realm-js: [RN 0.47.0]ReactPackage.java remove createJSModules function

Created on 2 Aug 2017  路  3Comments  路  Source: realm/realm-js

Could I change RealmReactPackage.java

    @Override
    public List<Class<? extends JavaScriptModule>> createJSModules() {
        return Collections.emptyList();
    }

to

    // @Override
    public List<Class<? extends JavaScriptModule>> createJSModules() {
        return Collections.emptyList();
    }

?

T-Enhancement

Most helpful comment

It looks like we need to remove the method rather than just the @override annotation.

As I understand if you remove whole method, support for RN < 0.47 will be broken, only @override annotation should be removed

All 3 comments

It is listed under Breaking Changes: https://github.com/facebook/react-native/releases/tag/v0.47.0
I guess we must remove the method moving forward.

It looks like we need to remove the method rather than just the @override annotation.

It looks like we need to remove the method rather than just the @override annotation.

As I understand if you remove whole method, support for RN < 0.47 will be broken, only @override annotation should be removed

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ugendrang picture ugendrang  路  3Comments

ashah888 picture ashah888  路  3Comments

texas697 picture texas697  路  3Comments

fever324 picture fever324  路  4Comments

blagoev picture blagoev  路  3Comments