Reakit: Potential React warning triggered by useToolbarState

[youknowriad]

On Gutenberg when doing:

• Type * on an empty paragraph
  
  
  
  • Click "cmd + z" to undo
  
  

It triggers a React warning with the following stack trace

And if I'm reading right, this is the only place where this could be triggered right?

https://github.com/WordPress/gutenberg/blob/692ec8cb40f8372484da4ddb8930fe4fecf6e8a7/packages/components/src/toolbar/toolbar-container.js#L20

Reproduction
https://codesandbox.io/s/wordpress-slotfill-reakit-toolbar-nw01x

[open-collective-bot[bot]]

Hey @youknowriad :wave:,

Thank you for opening an issue. We'll get back to you as soon as we can.
Please, consider supporting us on Open Collective. We give a special attention to issues opened by backers.

If you use Reakit at work, you can also ask your company to sponsor us :heart:.

[tom-sherman]

Hi @youknowriad, thanks for this! Do you think you could create a minimal CodeSandbox demonstraighting this error?

[diegohaz]

Looks like it only happens in the context of Gutenberg, and I suspect it's somehow related to https://github.com/WordPress/gutenberg/issues/17355#issuecomment-629934483

I'll try to put together a minimal reproduction and see if there's something we can do on Reakit to prevent it.

[youknowriad]

@diegohaz That's great, thanks for your help. I admit I don't know enough knowledge in this area of our codebase to be able to create a minimal reproduction CodeSanbox.

[diegohaz]

Here's a reproduction of the problem: https://codesandbox.io/s/wordpress-slotfill-reakit-toolbar-nw01x

Working on a fix.

[youknowriad]

Thanks for the fix @diegohaz