Readthedocs.org: Plotly plots show locally but not on RTD

juanlu-poliastro.readthedocs.io/en/latest/examples/Plotting%20in%203D.html

Then I get errors coming from require.js and the plot doesn't load in Firefox nor Chrome.

I do see the plots in Firefox 61.0.1 (64-bits) on Linux Arch even with the errors that are shown in the Firefox console. On the other hand in Chrome it works, does not work, crashes my Chrome and behaves in a crazy way :grin:

We will need to research more about this, but I can tell that after refreshing a couple of times the page from Chrome Versión 61.0.3163.79 (Build oficial) (64 bits) (with and without cache) I was able to see the graph:

I'd say that there is something that depends on the order of loading those js libraries...

I'm not sure how to continue debugging this, though.

Thanks for your prompt response @humitos! If there's anything I can do to help from my side, please let me know.

I created a repo with a much simpler test case to display the buggy behavior:

https://github.com/Juanlu001/rtd-js-test

Result:

https://rtd-js-test.readthedocs.io/

There are two branches (one with the RTD theme and one with Alabaster) and five notebooks that display four different combinations + an interactive widget.

• With the Alabaster theme, all the five notebooks are shown and no relevant JavaScript errors appear in the developer console, both locally and at https://rtd-js-test.readthedocs.io/en/alabaster/.
• With the RTD theme, there are several different behaviors:
  
  
  
  • The notebooks that do not add require.js at the top (as suggested in https://github.com/plotly/plotly.py/issues/1033#issuecomment-402894617) raise Uncaught ReferenceError: requirejs is not defined and Uncaught ReferenceError: require is not defined errors and do not show anything, neither locally nor online.
  
  
  • The notebooks that add require.js at the top show very long errors and intermittently show the plot online (in Firefox or Chrome) or almost always locally.
  
  
  • The notebook that uses a widget works everywhere.
  
  

I still did not have time to test what @Blendify started in https://github.com/rtfd/sphinx_rtd_theme/pull/545, but the fact that Alabaster does not show display this behavior would indicate that there it's a RTD + RTD theme specific behavior.

@jonmmease suggested in https://github.com/plotly/plotly.py/issues/1033 that the problem might be require.js rather than jQuery.

Also, although this was first reported in https://github.com/spatialaudio/nbsphinx/issues/128, I doubt that this can be fixed on the nbsphinx side (cc @mgeier, @bluprince13).

My current workarounds are:

• Use widgets, because they seem to work better.
• Use an unreleased version of rtd_sphinx_theme that should work.
• Use a totally different theme.

I acknowledge that we have to conceal expectations and settle on who should handle this, so can we try to reach an agreement?

By the way, one of the JS errors I'm getting contains the string "/Users/anthony/dev/readthedocs.org/bower_components/jquery/jquery.js". Is this normal?

By the way, one of the JS errors I'm getting contains the string "/Users/anthony/dev/readthedocs.org/bower_components/jquery/jquery.js". Is this normal?

Can you tell me where you see this error? I don't see it on
https://rtd-js-test.readthedocs.io/
or
https://rtd-js-test.readthedocs.io/en/alabaster/

As to fixing the underlying issue, that will be done here:
https://github.com/rtfd/sphinx_rtd_theme/pull/545

Until then, try the workaround documented here:
https://github.com/rtfd/sphinx_rtd_theme/issues/328#issuecomment-420011564

In general, you get better performance by loading JS at the end of the page rather than in the head as loading JS blocks rendering until it is fetched. However, no other Sphinx theme seems to care about that performance so I guess the RTD theme won't either.

I see that error here: https://rtd-js-test.readthedocs.io/en/latest/Connected%20-%20require.js%20Hack.html

Glad to know https://github.com/rtfd/sphinx_rtd_theme/pull/545 is still under consideration, I was worried because the branch is lagging a bit behind :) The problem with the workaround is that it's not that easy to modify the output of nbsphinx, as it's not a .rst file where you insert the contents of the notebook. Right @mgeier?

Thanks. I see that in the error and that's very weird. However, I don't think that's the cause of the error.

It's definitely an oddity but that is not the source of the problem. The source of the problem is that _ was used before underscore.js was loaded.

In https://github.com/rtfd/readthedocs.org/issues/4787#issuecomment-431839767 I encountered the same problem. I fixed it by (copy from that issue):

def remove_jquery_and_underscore(app):
    # We need to remove the jquery and underscore file that are
    # added by default because we already add it in the <head> tag.
    remove = lambda x: not any(js in x for js in ['jquery', 'underscore'])
    if hasattr(app.builder, 'script_files'):
        app.builder.script_files = [x for x in app.builder.script_files
                                    if remove(x)]

def setup(app):
    app.connect('builder-inited', remove_jquery_and_underscore)

Using my setup I am able to correctly show plotly plots, for example https://adaptive.readthedocs.io/en/latest/docs.html#adaptive-learnernd.

I used @Blendify branch at https://github.com/rtfd/sphinx_rtd_theme/pull/545 and it worked:

https://rtd-js-test.readthedocs.io/en/fork-theme/

No JS errors whatsoever, all the plots work. It would be great to have this in master but I understand ther might be some reservations. In any case, I'm stuck with this (until at least someone rebases it).

I tried rebasing PR https://github.com/rtfd/sphinx_rtd_theme/pull/545, but this is indeed quite hard. But the end result should really be just moving a few lines around, so I made a new PR doing just that: https://github.com/rtfd/sphinx_rtd_theme/pull/696.

Can you please check out if that works for you?

@mgeier thanks! @Blendify already rebased his and it's working, so I will use that instead.

https://github.com/rtfd/sphinx_rtd_theme/pull/545 was merged, should we wait for a new release of the theme or close this now?

We can close.

Rebuilding @Juanlu001's repo locally with sphinx_rtd_theme:0.4.3 does not appear to work. Trying the above fixes do not appear to work either. Oddly, inspecting the debugger shows no issues, the image simply does not appear. Has something changed in the last several months that would prevent this?

@dgasmith, we had the same problems in Adaptive.

I am not a javascript expert but we solved it in Adaptive, basically by copying theme.js to _static/js and commenting out the first line.

I am not sure whether the presence of that line (loading jQuery with require.js when it's already loaded) is a bug or not. Maybe @stsewd or @Blendify would know?

Before deeming this a problem with sphinx_rtd_theme, let me repeat the tests. The ipywidgets ecosystem is evolving very fast, sometimes in a not so organic way, and perhaps there's something that broke on the other side.

@Juanlu001, in Adaptive we use ipywidgets, plotly and holoviews plots and most of them broke. I solved it by what I wrote above.

Again, I don't know whether this is the best solution.

Glad to know it's working for you @basnijholt. For me, however, things look a bit more complicated because I tested several combinations of plotly and sphinx-rtd-theme with the latest versions of all the packages, including ipywidgets, and... Now nothing seems to work.

@jonmmease is reworking Plotly rendering in https://github.com/plotly/plotly.py/pull/1474, so perhaps that has the potential of fixing these issues (once and for all?)

In the meanwhile, I will try to go back to some known configuration that worked and identify where the problem is, although it will take me some time.

_Amend_: In alabaster everything seems to work, but now I can't find any version of plotly + sphinx-rtd-theme that does, not even the fork I used to use.

(Clarified previous comment with respect to alabaster)

@basnijholt Your solve work great! One small addendum, we need to to add https://cdnjs.cloudflare.com/ajax/libs/require.js/2.3.4/require.min.js to the JS headers as well. You pick this up via holoviews, but will not work for everyone.

Plotly merged a significant refactor of their render machinery, so it would be nice to repeat the tests with the master version (or wait for the next release if you're patient enough):

https://github.com/plotly/plotly.py/pull/1474#issuecomment-481658471

I am using alabaster, and graphs are not shown. I am not sure if it's a rtd or nbsphinx issue.
If I export the notebook with jupyter nbconvert --to html --execute docs/source/nbs/in-short.ipynb graphs are visible.
https://arche.readthedocs.io/en/docs/nbs/in-short.html

@manycoding I see a ReferenceError: require is not defined in the web developer tools. I'm a bit lost on what are the best practices now, but perhaps just including require.js will fix your issue.

@Juanlu001 Yeah, that's probably nbsphinx (or plotly) issue since I see that nbconvert includes require.js.

An update after https://github.com/rtfd/readthedocs.org/issues/4367#issuecomment-476603124: I didn't rebuild rtd-js-test, but now things appear to be working in my upstream project https://github.com/poliastro/poliastro/issues/530#issuecomment-498131602. I feel bad bothering everybody about this already, it's also tiring for me :) I don't have time now to know exactly what changed in the middle or what versions are the good ones, but in any case, I consider this done (hope it lasts!)

My issue is being fixed in https://github.com/spatialaudio/nbsphinx/pull/302