Readthedocs.org: Stable versions are broken

[agjohnson]

For instance: http://readthedocs.org/projects/docs/builds/6938938/

[stsewd]

Related issues https://github.com/rtfd/readthedocs.org/issues/3837

[humitos]

Previous stable passing is this one: http://readthedocs.org/projects/docs/builds/6933018/

Note that the only difference is that now the git checkout command is adding the origin/ to the commit. Guessing, I would say that maybe some output has changed between Git 1.9 and Git 2.7.4 that was upgraded with the Ubuntu upgrade (a couple of days ago). Not sure, anyway.

[stsewd]

@humitos I think it is due the git upgrade, on my local instance I can't reproduce this. But the checkout commands are different

[stsewd]

Now I was able to reproduce this on my local instance with this project https://github.com/irmen/Pyro4

[stsewd]

Found it!

The error is here

https://github.com/rtfd/readthedocs.org/blob/f3c0c0aa33c6017951b900e540d61ef36ea71d4e/readthedocs/vcs_support/backends/git.py#L250-L252

https://github.com/rtfd/readthedocs.org/blob/f3c0c0aa33c6017951b900e540d61ef36ea71d4e/readthedocs/vcs_support/backends/git.py#L256-L258

This is because before code was the original exit_code of the command, but after #3831(I think) the original exit_code is losed. This is something I was wondering while writing tests on https://github.com/rtfd/readthedocs.org/pull/3764#issuecomment-375827453

[stsewd]

So, probably other places that rely on the original exit_code are going to be in trouble...

[agjohnson]

@stsewd great find! i think you're right

[humitos]

Just a note for next week.

We should be careful with all the record_as_success that use the exit code to decide something.

[agjohnson]

Tags and stable are working again. Closing.

[stsewd]

@agjohnson other projects still has this issue, can be tracked on https://github.com/rtfd/readthedocs.org/issues/3837 anyway.