Readthedocs.org: https page using http for some media

Created on 27 Dec 2017 · 8Comments · Source: readthedocs/readthedocs.org

This produces Firefox to warning users.

$ wget -O - https://readthedocs.org/sustainability/ | rg "http://"  
--2017-12-26 20:38:06--  https://readthedocs.org/sustainability/
Cargado certificado CA '/etc/ssl/certs/ca-certificates.crt'
Resolviendo readthedocs.org... 162.209.114.75
Conectando con readthedocs.org[162.209.114.75]:443... conectado.
Petición HTTP enviada, esperando respuesta... 200 OK
Longitud: no especificado [text/html]
Grabando a: “STDOUT”

-                                                   [<=>                                                                                                   ]       0  --.-KB/s                   Read the Docs has <a href="http://www.alexa.com/siteinfo/readthedocs.org">grown substantially</a>
    <li><a href="http://docs.python-requests.org/en/latest/">Requests</a></li>
    <li><a href="http://sublime-text-unofficial-documentation.readthedocs.org/en/latest/">Sublime Text Community Docs</a></li>
    <li><a href="http://bootstrap-datepicker.readthedocs.org/en/latest/">Bootstrap Datepicker</a></li>
    <li><a href="http://julia.readthedocs.org/en/release-0.3/">Julia</a></li>
    <li><a href="http://doctrine-orm.readthedocs.org/en/latest/">Doctrine ORM</a></li>
    <li><a href="http://docs.sequelizejs.com/en/latest/">Sequelize</a></li>
    Our servers are graciously sponsored by <a href="http://www.rackspace.com/">Rackspace</a>, at a value of $2,000 each month.
    You can view the full list of <a href="http://docs.readthedocs.io/en/latest/sponsors.html#past-sponsors">past sponsors</a> in our documentation.
            <a href="http://onap.org"><img src="http://wiki.onap.org/?preview=/1015829/1018963/onap_704x271%20copy.png" alt="Kenny Paul" /></a>
-                                                   [ <=>                                                                                                  ]   6,92K  5,78KB/s                             <a href="http://blog.readthedocs.com/">Blog</a>
    ga.src = ('https:' == document.location.protocol ? 'https://ssl' : 'http://www') + '.google-analytics.com/ga.js';
-                                                   [  <=>                                                                                                 ]  11,49K  9,60KB/s    en 1,2s    

2017-12-26 20:38:10 (9,60 KB/s) - escritos a stdout [57153]

Improvement

Source

humitos

All 8 comments

@humitos to help new contributors who may want to grab this: all that is needed is to grep for http and replace it with https, right?

RichardLitt on 27 Dec 2017

Mmm... I think that it's only needed to use HTTPS in img src and link css tags. The links with a is not needed to replace.

humitos on 28 Dec 2017

👍1

If you're a beginner and you want to take this, feel free to ask questions here or on Slack, new contributors!

RichardLitt on 29 Dec 2017

This particular issue seems to be in a readthedocsext template. But it doesn't seem to exist when I install and run this project. Any hint?

iambibhas on 30 Dec 2017

👍1

Hi @RichardLitt I would like to take this. However, I tried to grep -rnH "img src=" and all results seem to have had https / uses {{ }} tag / uses {% static '...' %} tag provided by Django.