Readthedocs.org: Unimplemented ModerationActionManger model in comments app

[smcoll]

readthedocs.comments.models.ModerationActionManager is unimplemented, and contains a single current_approvals method which doesn't return anything. This is probably a cleanup issue.

[stsewd]

The whole comments app needs to be removed? I don't know where it is used on the site right now.

[shreyateeza]

@smcoll I too have the same query as @stsewd . Please explain. I am new here and would like to work on this issue.

[smcoll]

From what i remember, i just found a model which wasn't used anywhere while doing code cleanup. It'd be up the the maintainers to determine a course of action here.

[shreyateeza]

@humitos Please throw some light on this issue.

[RichardLitt]

@ericholscher or @agjohnson may know more. :)

[ericholscher]

The comments app was a dead end, and should probably be deleted. It was our attempt at doing comments on the site, but we never got it working well enough to ship it at scale.

[shreyateeza]

@ericholscher, you mean this needs to be deleted. Right?

[RichardLitt]

@shreyateeza Sounds like it to me.

[humitos]

Yeah, please. If you have some time to work on this, remove the whole app. People is using sphinx-disqus for comments, which is not great, but this doesn't work as Eric said. We can recover this code in the future in case we want to continue this work.

In the meanwhile, if we remove it, the code won't interfers in our lives :)

[shreyateeza]

Will do it @humitos. Please assign this issue to me. :)
You mean to say that I have to remove the whole comments folder. Right?

[humitos]

I can't assign the issue, sorry.

Yes, remove the folder and make the necessary changes to keep the code working :)