Readthedocs.org: Deleted repository not detected

[beruic]

Details

I have deleted the repository at https://github.com/beruic/bootstrap-tagsinput, but it does not disappear when i refresh in the repository importer at https://readthedocs.org/dashboard/import/.

[humitos]

I confirm that I'm able to reproduce this. I created a repository called 1 in GitHub and I imported without problem to RTD. Then I deleted the project from RTD and also from GitHub. After that I hit re-sync in RTD and I still seeing my 1 repository to be able to import.

If I try to re-imported after deleted from GitHub I receive this error: https://readthedocs.org/projects/my1/builds/5489577/

Failed to import project: Failed to get code from 'https://github.com/humitos/1.git' (git fetch): 128 Stderr: fatal: could not read Username for 'https://github.com': No such device or address

[agjohnson]

Correct, our sync repository function doesn't remove existing RemoteRepository objects, nor does it attempt to discover which should be removed.

Some decisions to make here:

• Is deleting the RemoteRepository object the most correct thing?
• Should we also disable the project if the repository goes away?

I would say deleting is fine, as long as we ensure it doesn't cascade to connected projects.

I would also say that disabling the project doesn't make sense, as this could simply be a matter of losing access to a fork of a repository. Perhaps we need to think more on this case though.

[agjohnson]

Also, related: #2759. Not sure if we block on this issue, but #2759 changes some of the decisions here.

[beruic]

I just checked BTW. The deleted repository still appears in my list.

[humitos]

After #7183, GitHub integration in cleaning up old RemoteRepository from that user _only if it's not connected to a Project_. This will have impact in the "Import Project" page that won't show stale repositories that do not exist anymore.

The same work/code needs to be ported to GitLab and Bitbucket to be able to close this issue.