Readthedocs.org: Still showing .org under "Short URLs"

[chadwhitacre]

Based on "Securing Subdomains," I would expect to see foo.readthedocs.io under "Shorter URLs" in the sidebar on project pages, but I still see foo.readthedocs.org. E.g.:

https://readthedocs.org/projects/gratipay/

Looks like PRODUCTION_DOMAIN is a config value. Not sure how that interacts with the management interface for the site. I suspect fixing this could be more complicated than simply changing that value in settings, but maybe it _is_ that simple. :-)

[ronakkhunt]

Hi @agjohnson
I just configured local setup would like to start with this bug.

[agjohnson]

@ronakkhunt sure thing, feel free to open a PR and we can work from there. The change should be a minor template change. I believe -- without looking at it -- that the template just uses a hard-coded short URL.

[ronakkhunt]

@agjohnson No it's not hard-coded. it using PRODUCTION_DOMAIN value from settings.

Snippet:
<p>
<a href="http://{{ project.slug}}.{{ PRODUCTION_DOMAIN }}">{{ project.slug }}.{{ PRODUCTION_DOMAIN }}</a><br>
{% if PRODUCTION_DOMAIN == "readthedocs.org" %}
<a href="http://{{ project.slug}}.rtfd.io">{{ project.slug }}.rtfd.io</a>
{% endif %}
</p>
Changing PRODUCTION_DOMAIN value in not an option here.
I can hard-code "readthedocs.io", but what is this if condition for?

[agjohnson]

@ronakkhunt the correct setting is PUBLIC_DOMAIN. The other instances of hardcoded domains can be changed from .org -> .io

[ronakkhunt]

@agjohnson
Okey, so final HTML block will be like this...

  <p>
    <a href="http://{{ project.slug}}.{{ PUBLIC_DOMAIN }}">{{ project.slug }}.{{ PUBLIC_DOMAIN }}</a><br>
    {% if PUBLIC_DOMAIN == "readthedocs.io" %}
    <a href="http://{{ project.slug}}.rtfd.io">{{ project.slug }}.rtfd.io</a>
    {% endif %}
  </p>

Also I have added PUBLIC_DOMAIN in context_processor.py (or it can be added in context of view specifically)

Though I do not have production settings' file, I have tested it in local setup given PUBLIC_DOMAIN value in production setting is set as readthedocs.io.

[ronakkhunt]

@agjohnson

[magnunleno]

@ronakkhunt are you still looking at this issue? I'm considering to give it a try too.

[agjohnson]

This looks fine, @ronakkhunt could you open a PR for this?

[ronakkhunt]

Okey,
@agjohnson Since this is not a bug, I am going to make PR from master branch.

[ronakkhunt]

@agjohnson https://github.com/rtfd/readthedocs.org/pull/2335

[berkerpeksag]

This was done in https://github.com/rtfd/readthedocs.org/commit/c968ff240e993fe50229098c10720637e16b11b2. Closing as 'fixed', thanks!

[chadwhitacre]

I'm still seeing the .org at https://readthedocs.org/projects/gratipay/. What's your release schedule like?