Reactor-core: Context is not propagated in Junit5 nested class

[eximius313]

Expected behavior

Both tests pass

Actual behavior

Only test in main class pass

Steps to reproduce

Run the test:

@ExtendWith(SpringExtension.class)
@TestExecutionListeners(MockitoTestExecutionListener.class)
class ContextTest {

    @Nested
    class Nest {

        @Test
        void testContext() {
          StepVerifier.create(Mono.just(1).map(i -> i + 10),
          StepVerifierOptions.create().withInitialContext(Context.of("foo", "bar")))
              .expectAccessibleContext()
              .contains("foo", "bar")
              .then()
              .expectNext(11)
              .verifyComplete();
        }
    }

    @Test
    void testContext() {
      StepVerifier.create(Mono.just(1).map(i -> i + 10),
      StepVerifierOptions.create().withInitialContext(Context.of("foo", "bar")))
          .expectAccessibleContext()
          .contains("foo", "bar")
          .then()
          .expectNext(11)
          .verifyComplete();
    }
}

Reactor Core version

3.2.0.RELEASE

JVM version (e.g. java -version)

9.0.4

[eximius313]

Ok, solved. You need to add ReactorContextTestExecutionListener.class to @TestExecutionListeners

[eximius313]

False alarm, it made things even worse...

[bsideup]

Hi @eximius313,

Thanks for your report! I tried to run the code you provided but I did not observe any test failure, both are passing.

Could you please provide more information about your environment?
e.g. I see SpringExtension and Mockito's extension, which versions of both are you using?

Thank you!

[anilewek]

Hi @bsideup , thanks for your response.

We use spring-test 5.1.0.RELEASE and spring-boot-test:2.1.0.M4

The nested test fails with reason: java.lang.AssertionError: No propagated Context

[bsideup]

@anilewek does it also fail if you update to the release version of spring-boot-test (2.1.0.RELEASE)?

[anilewek]

@bsideup yes, it still fails with the same error.

[bsideup]

Ok, I was able to reproduce it, but only when 'org.springframework.security:spring-security-test' is added to the classpath.
@anilewek could you please confirm that you have it?

Meanwhile, I'll check with Spring Security folks why it happens.

[eximius313]

I confim (I have it as transitive dependency)

[bsideup]

Ok, @Nested is not the cause.

Reproduced with:

@ExtendWith(SpringExtension.class)
class ContextTest {

    @Test
    void testContext() {
        StepVerifierOptions stepVerifierOptions = StepVerifierOptions.create()
                .withInitialContext(Context.of("foo", "bar"));

        StepVerifier.create(Mono.just(1), stepVerifierOptions)
                .expectAccessibleContext()
                .contains("foo", "bar")
                .then()
                .verifyComplete();
    }
}

it works if you annotate test class with @TestExecutionListeners(MockitoTestExecutionListener.class) but fails without it. Will check why.

@eximius313 @anilewek it also means that you can temporary workaround the bug by annotating your nested class with @TestExecutionListeners(MockitoTestExecutionListener.class)

[eximius313]

Thanks

[bsideup]

Hi @eximius313,

Was about to follow up :)

I think we were able to identify the problem and the fix will be included in the next release.
Meanwhile, it would be nice if you can test it with a SNAPSHOT version:
https://projectreactor.io/docs/core/release/reference/index.html#_milestones_and_snapshots

Thanks!

[anilewek]

I can confirm that the error does not occur with version 3.2.3
Thanks!