Reactivesearch: ReactiveList renderItem introduces an unexpected new wrapper <span /> element which can break existing UIs

Created on 14 Sep 2020  路  2Comments  路  Source: appbaseio/reactivesearch

Affected Projects
React

Library Version: x.y.z
3.12.4

Describe the bug
Looks like with the latest release, the ReactiveList renderItem() function wraps it's output in a <span>. This could arguably break a lot of UIs which use CSS frameworks which follow the pattern of:

<div class="columns">
  <div class="column"></div>
</div> 

by injecting this new span element:

<div class="columns">
  <span id="0i8asdf-987asdf">
    <div class="column"></div>
  </span>
</div> 

It's broken UIs in 3 of our applications, and not sure how to work around this. Is there any way to turn off the behavior of the new <span> wrap?

To Reproduce
Steps to reproduce the behavior:

View the source of any component rendered via the renderItem() function of the ReactiveList component.

https://opensource.appbase.io/playground/?path=/story/result-components-reactivelist--basic

Expected behavior
No extra element wraps the expected rendered component. Or a configuration option exists to specify what type of element it is and possibility to add classes to it?

Screenshots
image

Desktop (please complete the following information):

  • OS: Mac
  • Browser: all
  • Version: any
bug

Most helpful comment

@bietkul Thank you so much. ReactiveSearch is awesome and just keeps getting better. Thanks so much for all the open-source hard work.

All 2 comments

@adamjarling This issue has been fixed in v3.12.6.

@bietkul Thank you so much. ReactiveSearch is awesome and just keeps getting better. Thanks so much for all the open-source hard work.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

tiagogm picture tiagogm  路  3Comments

vharitonsky picture vharitonsky  路  4Comments

dmce picture dmce  路  3Comments

metagrover picture metagrover  路  4Comments

rbeers picture rbeers  路  3Comments