Reactive: NETSDK 1086 warning when referencing 4.3.1 and UseWindowsForms

[jeremyVignelles]

Hi,
When referencing System.Reactive in a WPF project using the Microsoft.NET.Sdk.WindowsDesktop SDK, both UseWindowsForms and UseWPF, and .NET core 3.1, I have this warning:

1>C:\Program Files\dotnet\sdk\3.1.100\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(39,5): warning NETSDK1086: A FrameworkReference for 'Microsoft.WindowsDesktop.App' was included in the project. This is implicitly referenced by the .NET SDK and you do not typically need to reference it from your project. For more information, see https://aka.ms/sdkimplicitrefs

Library version : 4.3.1

Tried with both VS2019 and dotnet build.

You can find an example here : https://github.com/jeremyVignelles/repro-dotnet-reactive

[jeremyVignelles]

Any update ?

[jeremyVignelles]

Ping?
Is there anything else I need to do to help with that bug?

[jeremyVignelles]

This seems to be cause by the Framework Reference in this file https://www.github.com/dotnet/reactive/tree/master/Rx.NET%2FSource%2Fsrc%2FSystem.Reactive%2Fbuild%2FSystem.Reactive.targets but I'm clueless about how it could be fixed and what target it will break by removing the line, because I assume it's there for a reason...

If anyone can tell...

[ltrzesniewski]

This change was introduced in #1007 to fix #998.

@clairernovotny I'm not quite sure what's the best way to fix this, do you think that changing the condition to the following would be a good idea?

'$(UseWindowsRxVersion)' == 'true' and !@(FrameworkReference->AnyHaveMetadataValue('Identity', 'Microsoft.WindowsDesktop.App'))

[jeremyVignelles]

Thanks a lot @ltrzesniewski ! 🎉