Reaction: [3.0.0] Accounts query has duplicate field shopId

Created on 9 Jan 2020  路  5Comments  路  Source: reactioncommerce/reaction

The accounts query includes the field shopId twice with different description:

https://github.com/reactioncommerce/reaction/blob/8ed0165a7ab2c07ddfa394317d12c34ca57c37ee/src/core-services/account/schemas/account.graphql#L444
https://github.com/reactioncommerce/reaction/blob/8ed0165a7ab2c07ddfa394317d12c34ca57c37ee/src/core-services/account/schemas/account.graphql#L447

Versions

latest 3.0

good first issue
Source
picture janus-reith

All 5 comments

can good first issue tag be added?

HarisSpahijaPon picture HarisSpahijaPon on 14 Jan 2020
👍1

@spencern This looks like an easy cleanup that could be included in the current cycle.

manueldelreal picture manueldelreal on 14 Jan 2020
👍1

@manueldelreal Indeed, however it's still there :D Would've sent a PR but thought one of you would be quicker.

janus-reith picture janus-reith on 23 Jan 2020

Taking this since I'm refactoring that query for #6006 anyway

aldeed picture aldeed on 28 Jan 2020
👍1

resolved in #6060

willopez picture willopez on 30 Jan 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

zikeji picture zikeji  路  4Comments
spencern picture spencern  路  4Comments
nnnnat picture nnnnat  路  4Comments
ajporlante picture ajporlante  路  4Comments
coooolers picture coooolers  路  4Comments