Reaction: Flakey CI timeout failures

[focusaurus]

Our CI tests have flakey intermittent timeout failures. Most recently https://circleci.com/gh/reactioncommerce/reaction/48337

I believe this should be solvable in a good way we just need to dig in and work the problem. Will put this issue into the DevX pod backlog.

[focusaurus]

Comment from @mikemurray in slack:

Maybe this test needs to be wrapped in a Reaction.whenAppInstanceReady(() => { /* tests */ }).

[kieckhafer]

Hate this error, happy to look into it.

[aldeed]

@mikemurray Is correct that first step should be to make sure all tests in every app-test file are wrapped in Reaction.whenAppInstanceReady.

Someone can also look through all the test files and remove any tests that are testing things that are no longer used. There may be some Meteor methods that client code no longer calls, which can be removed along with their Meteor tests.

[machikoyasuda]

• https://github.com/reactioncommerce/reaction/issues/5246
  related issue

[kieckhafer]

Resolved in #5317