Reaction: Product context menu has too many sections open

[spencern]

Expected behavior

When I open a section in the product editor action view within the PDP, other sections should close. When clicking a variant or option to open the editor for that variant or option, all other panels should close.

Actual behavior

The Taxable and Inventory tracking panels get stuck open and do not close or roll up when a different variant or option is selected.

Steps to reproduce the behavior

1. Open the default product
2. Click the variant
3. Click an option
4. Observe that certain panels are stuck open.

Versions

Node: 8.9.0
NPM: 5.6.0
Meteor Node: 8.9.3
Meteor NPM: 5.5.1
Reaction CLI: 0.27.0
Reaction: 1.8.0
Reaction branch: release-1.8.0
Docker: 17.12.0-ce

[prinzdezibel]

After reading the code, it's clear that this is not a bug fix anymore, but would represent an enhancement of existing UI components. In the screenshot below the current component layout is shown:

The idea of the Settings Card is to persist the expanded state of each card individually and independent of other card's state in local storage.

If we'd like to introduce constraints on the card's individual expanded states, we need to transfer the control over the combined state of the cards onto the parent component (e.g. Components.CardGroup or any other ancestor).

This would require an overhaul of the SettingCard component. Not only would it no longer be responsible for calculating the expanded state itself, but also would need additional changes in the way the header is rendered to allow the first panel (Components.Card) be a member of the whole group. This is because the first panel has icons in the card header which can't be done with the SettingsComponent yet.

This is certainly doable, but I wouldn't consider this a bug fix. The decision about how to proceed should be @Spencer's call.

[prinzdezibel]

Removed the bug label, as I would consider this an enhancement of the current functionality.

[spencer]

I don't think it should be my call, it should be @spencern 's call!

[prinzdezibel]

Man, this is the second, third, n-th? time already, that I got @spencern's nick wrong. sorry!

[zenweasel]

I spoke with @spencern and we agreed that we still classify this as a bug and we should proceed with it even though it may require more coding. Moving back into unassigned bugs

[kieckhafer]

Closing this, as 2.0 doesn't have this UI anymore.