Reaction: Order detail displayed twice when order is selected in Order Dashboard

[zenweasel]

Expected behavior

Order detail should only show up once

Actual Behavior

Shows up twice with inconsistent results

Steps to Reproduce the Behavior

1. Login as admin and enable shipping/payment
2. Place an item in cart and checkout
3. Place a second order
4. Go to order dashboard
5. Select an order
6. Observe order is listed in details pane
7. Select 2nd order.
8. Observe that previous order and current order are both visible in the detail pane

Versions

Node: 7.10.0
NPM: 5.3.0
Meteor Node: 4.8.4
Meteor NPM: 4.6.1
Reaction CLI: 0.12.0
Reaction: 1.5.0
Reaction branch: spencer-fix-2955-order-publication-userid (marketplace)
Docker: 17.06.2-ce

[joykare]

Notes

• It displays twice because of this line right here: https://github.com/reactioncommerce/reaction/blob/marketplace/imports/plugins/core/orders/client/templates/workflow/workflow.html#L4
• When you have an order and ship, two shipping items are added into the shipping array in the DB
• Next step: figure out why there are two shipping items for one order and if they are supposed to exist in the first place

[joykare]

• Observed this behavior on old orders I had. By behavior I mean:

Unable to replicate this on new orders and after reaction reset.

~@zenweasel~ @kieha could you try reproducing this bug after a reaction reset/ just on new orders.

[kieha]

Every first order of every user seems to come with two shipping objects that have the same shopId. The subsequent orders all have one shipping object. This is after a reaction reset.

[impactmass]

To add also, for those two shipping objects mentioned, there's a success/error field in there i.e shipping.shipmentQuotesQueryStatus.requestStatus. (cc @jm-wanja you mentioned this too somewhere, right?)

[joykare]

@impactmass seen it. Thanks for mentioning it.

Update

• Figuring out why this is happening

[zenweasel]

@joykare I see this issue all day with new orders and I'm constantly resetting. Let me try and drill down into some better reproduction steps.

[zenweasel]

I think the two shipping records is a bug introduced by me that I have fixed on #2847

[joykare]

@zenweasel just tested for this on your PR and its fixed (you could add this as a bug your PR resolves_unless you can reproduce it some other way)

• The shipping having two items for the same order was happening for the first order for every new user

[spencern]

Resolved by #2847