Reaction: Fix validation on PDP

[zenweasel]

All fields that are required or have a set type need to provide some user feedback.

[zenweasel]

This should be part of the style guide, but for now we need a way to consistent display errors that require action.

[zenweasel]

Right now everything is just being thrown up in a toast. This is actually a regression for some of these fields like price and dimension where we would see the field highlighted, etc.

[zenweasel]

I should be able to enter $0.00 as a valid price on a product. Sometimes things are free. Right now I get a "Price is required" toast.

[zenweasel]

We don't need to wait for design here, I think we all know the basics of how validation should work. The field should be focused, the error should show next to the field, etc.

[rymorgan]

@zenweasel totally agree. If you guys take a stab at it and send it my way when it's done. But yes it should just as you describe.

[zenweasel]

I just talked to @kieckhafer and he is willing to take this on. Hopefully we can expand the Autoform replacement work that @mikemurray has been working on

[rymorgan]

@kieckhafer let me know when you work on this and we can talk through how the validation should be styled. I'm hoping this is something that does some automatic validation magic with our forms so we're consistent everywhere.

[aaronjudd]

Removed "critical impact" with the merge of #2531

[mikemurray]

This PR (https://github.com/reactioncommerce/reaction/pull/2893) should be able to close this issue once it's merged

[mikemurray]

Also assigned @kieckhafer since he's fixing this in his PR #2893

[kieckhafer]

Closed by #2893