Reactgo: Loose Dep's

Created on 11 Sep 2016  Â·  6Comments  Â·  Source: reactGo/reactGo

Anybody know if there's anything depending on chai or deep-equal?

I've had both removed from my own build for a while... No issues, and only seeing one instance of either across the entire repo.

Guillotine?

_Other potentials:_ immutable, invariant, kerberos, node-libs-browser

_Note:_ duplicate dev-dependency redux-mock-store in dependencies.

Sorry if any of these are obvious necessities, my build is pretty light.

Most helpful comment

@caranicas greenkeeper seems like overkill, it clogs-up the commit log

All 6 comments

Kill it!!

On Mon, 12 Sep 2016 02:28 John Rodler [email protected] wrote:

Anybody know what's depending on chai?

I've had it removed from my own build for a long time... Never had any
issues, and I only see one instance of "chai" across the entire repo.

Guillotine?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/reactGo/reactGo/issues/504, or mute the thread
https://github.com/notifications/unsubscribe-auth/ADnMbQ_5ZVYcDlYQ9Gk8Qg-oMLa-WYotks5qpCwTgaJpZM4J6CyL
.

Hehe nice work

On Mon, 12 Sep 2016 06:49 choon ken ding [email protected] wrote:

Kill it!!

On Mon, 12 Sep 2016 02:28 John Rodler [email protected] wrote:

Anybody know what's depending on chai?

I've had it removed from my own build for a long time... Never had any
issues, and I only see one instance of "chai" across the entire repo.

Guillotine?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/reactGo/reactGo/issues/504, or mute the thread
https://github.com/notifications/unsubscribe-auth/ADnMbQ_5ZVYcDlYQ9Gk8Qg-oMLa-WYotks5qpCwTgaJpZM4J6CyL
.

anything to reduce the number of greenkeeper PRs

Yes. Agreed. Kill them with 🔥

If you get to test them and have no issues, just merge them! 😈

@caranicas greenkeeper seems like overkill, it clogs-up the commit log

I agree with @jrodl3r npm update -S is enough

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ZeroCho picture ZeroCho  Â·  8Comments

psimyn picture psimyn  Â·  6Comments

choonkending picture choonkending  Â·  8Comments

azamatsmith picture azamatsmith  Â·  6Comments

slavab89 picture slavab89  Â·  6Comments