React: Devtools resize Component State/Props pane

Created on 17 Nov 2019  路  11Comments  路  Source: facebook/react

Do you want to request a feature or report a bug?
I would like to request a feature

What is the current behavior?
Resizing the state/props pane in Component Tab

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to your JSFiddle (https://jsfiddle.net/Luktwrdm/) or CodeSandbox (https://codesandbox.io/s/new) example below:

What is the expected behavior?
Allow resizing pane

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
Devtools 4.2.0 and Chrome Version 78.0.3904.97

image

Developer Tools Enhancement good first issue (taken)

Most helpful comment

Looking nice!

Should we also support vertical resizing when we are in this mode?

Seems like, ideally, resizing should work for both horizontal and vertical (and be remembered separately)

All 11 comments

I'd be happy to review a PR for this.

Hey @bvaughn !

Are we still looking at adding this feature?

Maybe we can have a checkbox in Settings -> General that will allows the user to force dock the Component State/Props/.. to the bottom instead of supporting resizing for that pane?

I can create a POC PR for it.

What do you think?

Resizability, yes. Would still be open to adding that behavior in.

A checkbox to force a bottom docking position- not really a fan of that.

Cool @bvaughn. I'll try and open a PR by the end of this week. I'll ping you again when it's done.

This issue is all yours! 馃槃

I've added the "good first issue (taken)" label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim.

Cheers!

*Progress so far:*

horizonta-resize

I have a question though, @bvaughn.

Should we also support vertical resizing when we are in this mode?

Screenshot 2020-02-13 at 13 09 27

Thoughts?

Note: The red vertical line is for debugging purposes 馃槅

Looking nice!

Should we also support vertical resizing when we are in this mode?

Seems like, ideally, resizing should work for both horizontal and vertical (and be remembered separately)

Almost done! (I expect to open the PR this Saturday).

Here's how it looks so far:

Horizontal Resize:

horizontal-resize

Vertical Resize:

vertical-resize

Looking good!

This is awesome!!

@bvaughn we can close this one 馃帀

Was this page helpful?
0 / 5 - 0 ratings

Related issues

krave1986 picture krave1986  路  3Comments

zpao picture zpao  路  3Comments

trusktr picture trusktr  路  3Comments

zpao picture zpao  路  3Comments

jvorcak picture jvorcak  路  3Comments