React: Consider using reactjs.org instead of fb.me in react's error/warning messages

Created on 11 Jul 2019  Â·  16Comments  Â·  Source: facebook/react

Hi,

Facebook is blocked in my country (and I think in some other countries) and links like https://fb.me/react-invalid-hook-call are blocked for me, in order to see the related documentation of the link I have to use VPN. so if is possible please use another link shortener service or point to reactjs.org directly.

Thanks.

Needs Investigation

Most helpful comment

We are considering this seriously. We are not sure when and how we'll do this, but it's on our minds. Thanks for the suggestion!

All 16 comments

We are considering this seriously. We are not sure when and how we'll do this, but it's on our minds. Thanks for the suggestion!

One more reason is that current links require fb account! Please make this priority.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

Not stale, I think we do want to do this sometime.

@bencefr I don’t think you’re right? Definitely does not require an fb account

@threepointone , it definitely does, since fb.me/... just redirects to facebook.com main page to sign up.

@bencefr I just tested https://fb.me/react-invalid-hook-call and it redirects me to https://reactjs.org/warnings/invalid-hook-call-warning.html without forcing me to log in into my facebook account.

My bad, the link I used had a typo and should have been a 404. The redirect works but I would be against using fb.me anyway.

More data for this, fb.me is blocked inside lots of corporate environments as it's considered "social networking". While I'm working on getting it unblocked in my own firm, I don't expect that to actually happen soon.

McAfee's TrustedSource categorizes fb.me as "Social Networking" which is enough for my company to block it. I tried to make them change this categorization to "Internet Services" (like bit.ly) but so far I haven't been successful, probably because fb.me (or any non-existing shortcut like fb.me/trololololololilol) redirects to facebook.com.
I will try to make it unblocked but I have little hope so having reactjs.org urls in logs would be an improvement.

I can't agree more with @val1984
This probably would help tons of developper working within company with gateway (McAfee is just one of the many existing ones)
Having a dedicated FQDN like reactjs.org is something that can be trusted
Using fb.me will never be whitelisted for many reason like redirect to facebook / analytics / etc ...

We are considering this seriously. We are not sure when and how we'll do this, but it's on our minds. Thanks for the suggestion!

@threepointone how did it go ?

@threepointone @gaearon
Sorry, my bad for creating the PR directly without asking. I was thinking about better to have working warning than waiting for perfect solution.

Redirect links might redirect to invalid links too, one of the example is fb.me/react-mock-scheduler

I would suggest to create something like _redirects netlify, so that the public contributors can helps to update/monitoring the links whether needed.

No worries. We appreciate the intent — it’s just unfortunate because that particular change isn’t something we can do.

I think your proposal with _redirect makes sense. Is this something you would be interested in implementing?

@gaearon Yes. I am happy to do it.

I can see that reactjs.org is hosting on Netlify, and it is already _redirects using in reactjs.org website _redirects on reactjs.org.

Any preferred path for the short link?
reactjs.org/{path}/{title}

I can start with link as the path, it can be change easily later on.

Thanks to @cylim for taking this issue and spending the time to solve it.

https://github.com/reactjs/reactjs.org/pull/3199
https://github.com/facebook/react/pull/19598

This will go out in 17.

Thx a lot for this @cylim

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jvorcak picture jvorcak  Â·  3Comments

kocokolo picture kocokolo  Â·  3Comments

hnordt picture hnordt  Â·  3Comments

varghesep picture varghesep  Â·  3Comments

krave1986 picture krave1986  Â·  3Comments