React: Missing assets for releases 16.7, 16.8, 16.8.1

[DavideDaniel]

Do you want to request a feature or report a bug?
Publishing mistake or bug with script? Unsure.

What is the current behavior?
The releases for 16.7, 16.8, 16.8.1 don't have any assets listed. When fetching remotely via automated build scripts, we're not getting anything past 16.6.1 from the assets array via github release apis.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to your JSFiddle (https://jsfiddle.net/Luktwrdm/) or CodeSandbox (https://codesandbox.io/s/new) example below:
Visible by referencing the json returned from https://api.github.com/repos/facebook/react/releases

What is the expected behavior?
Releases should have assets or should not in documentation that they won't if it's intentional.

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
16.6.3 was the last one with assets.

[bvaughn]

This was an oversight on my part. Our release script doesn't mention this in the post-publish instructions because I didn't know it was part of our process. I'll adjust the script this coming week when I'm back at work.

In the meanwhile, any one of us could snag the packages from NPM and attach them to a release.

[sophiebits]

@DavideDaniel Separately from fixing this, I'll say that the most reliable way to get these assets is to pull them from npm. That is the "source of truth" for our official releases.

[bvaughn]

Agreed with Sophie.

As an alternative to using NPM (directly) you could also fetch the assets from unpkg.com (add a "?meta" param to generate a list of files in the package– e.g. https://unpkg.com/[email protected]/?meta).

[DavideDaniel]

Right.. I think the issue was that we use github api to pull releases through a cron job, and this popped up when a team noticed that their versions of react were not updating past a certain point. We'll look at leveraging npm if we can, however, just something that could be automated into the release scripts possibly.

[bvaughn]

however, just something that could be automated into the release scripts possibly.

Even though the GitHub API seems to support automated release creation– I don't think it's something we would want to automate with the release script. It requires a changelog that we're pretty careful about curing and having more than one team member review to ensure a high quality. I don't think the effort of adding this to the script is worth it.

I'll try to make the messaging/prompt more meaningful so we don't forget to do this in the future, but we don't really intend for people to consume releases from GitHub– only NPM.

[DavideDaniel]

That's good to know. Will circulate this at work. =)

[bvaughn]

Release script messaging changes made in PR #14863

[bvaughn]

The past four releases correspond to the following packages and versions:

16.8.2 - 2019-02-14

• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]

16.8.1 - 2019-02-06

• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]

16.8.0 - 2019-02-06

• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]

16.7.0 - 2018-12-20

• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]

[bvaughn]

I've updated the past releases to point to the UMD artifacts in UNPKG.

Going to close this for now~