React: Warn when component has PropTypes rather than propTypes

Created on 10 Nov 2017  路  8Comments  路  Source: facebook/react

See https://github.com/reactjs/reactjs.org/issues/268#issuecomment-343402728.

Feels like an easy mistake to make, and easy for us to detect.

starter Enhancement good first issue (taken)
Source
picture gaearon

Most helpful comment

hey can I take this ?

picture M-ZubairAhmed on 10 Nov 2017
🎉3 👍3

All 8 comments

hey can I take this ?

M-ZubairAhmed picture M-ZubairAhmed on 10 Nov 2017
🎉3 👍3

@M-ZubairAhmed Just do it.

blling picture blling on 10 Nov 2017

could you please guide me to where to start with this issue? thank you

M-ZubairAhmed picture M-ZubairAhmed on 10 Nov 2017

Search the code for where we read .propTypes and add the check there.

gaearon picture gaearon on 10 Nov 2017

got it.

M-ZubairAhmed picture M-ZubairAhmed on 10 Nov 2017

is this done?

kotAPI picture kotAPI on 10 Nov 2017

It's taken by @M-ZubairAhmed.

gaearon picture gaearon on 10 Nov 2017
👍1

@gaearon Should this be closed now?

bs91 picture bs91 on 5 Dec 2017
Was this page helpful?
0 / 5 - 0 ratings

Related issues

bloodyowl picture bloodyowl  路  3Comments
MoOx picture MoOx  路  3Comments
tleunen picture tleunen  路  3Comments
trusktr picture trusktr  路  3Comments
Prinzhorn picture Prinzhorn  路  3Comments