React: Deduplicate "Render methods should be pure" warning

Created on 4 Oct 2017  路  5Comments  路  Source: facebook/react

Note: the task is already claimed.

Just saw this in a fiddle that has a nested update bug:

screen shot 2017-10-04 at 11 52 52

It would be nice to just dedupe them in the first place instead of calling console.error a thousand times.

Note: the task is already claimed.

Core Utilities Enhancement
Source
picture gaearon

Most helpful comment

I am interested in taking this up. This would be one of my first open source contributions and I am really excited about it :)

picture anushreesubramani on 4 Oct 2017
👍4

All 5 comments

Same for this one:

screen shot 2017-10-04 at 11 54 11

gaearon picture gaearon on 4 Oct 2017

I am interested in taking this up. This would be one of my first open source contributions and I am really excited about it :)

anushreesubramani picture anushreesubramani on 4 Oct 2017
👍4

Sounds great! You'll need to search the codebase to find where we fire these two warnings, and then add boolean variables for each. If we fire it once, we set a boolean. Next time we check a boolean before firing it, and skip if the boolean is already set.

gaearon picture gaearon on 4 Oct 2017
👍1

If you have any questions feel free to ping me here.

gaearon picture gaearon on 4 Oct 2017
👍1

Fixed in https://github.com/facebook/react/pull/11113.

gaearon picture gaearon on 7 Oct 2017
Was this page helpful?
0 / 5 - 0 ratings

Related issues

hnordt picture hnordt  路  3Comments
UnbearableBear picture UnbearableBear  路  3Comments
varghesep picture varghesep  路  3Comments
kocokolo picture kocokolo  路  3Comments
zpao picture zpao  路  3Comments