React: [website] Tutorial warning at 'Showing the moves'

[shaleh]

I am running the code locally, using npm start. All was going well until I hit this section.

$ npm -v
3.10.10
$ node -v
v6.11.3

Here is what I see:

Compiled with warnings.

./src/index.js
  Line 84:  Links must not point to "#". Use a more descriptive href or use a button instead  jsx-a11y/href-no-hash

Search for the keywords to learn more about each warning.
To ignore, add // eslint-disable-next-line to the line before.

I grabbed the current code from this link https://codepen.io/gaearon/pen/EmmGEa?editors=0010 and I get the same warning as in the code I typed in manually. The text talks about this warning:

Warning: Each child in an array or iterator should have a unique "key" prop. Check the render method of "Game".

Which I am not seeing.

[Haroenv]

These are both just warnings, but I fixed them by changing the link to a button and adding keys:

https://codepen.io/Haroenv/pen/PJjOaG?editors=0010

[shaleh]

Yes, I call them warnings. My point is I am not seeing the warnings the guide says I should. Plus the warning is very explicit about using '#'. So I thought it should be brought to attention.

[Haroenv]

The warning is in the browser, not in the terminal (which is showing your eslint warnings)

[bvaughn]

Haroen's right. The "key" warning should be in your browser (in the developer console). The lint warning you mention is in the terminal and depends on which linting tool/configuration you're using.

I agree though that we should change the <a> in question to be a <button>.

[fumblehool]

@bvaughn I would like to solve this issue but I will need your guidance.

[bvaughn]

Looks like a few people have already submitted PRs related to this, @fumblehool (#11061, #11045, #11007, #11006). I think it's covered. 😄

[fumblehool]

@bvaughn please update the status of other issues also.

[bvaughn]

I don't know what other issue you're talking about.

[fumblehool]

I meant most of issues have PRs submitted by users. It is difficult to see if the issue is already covered or not.

[bvaughn]

I'm doing the best I can to review PRs and triage issues while also working on other things but there are way more people submitting PRs than there are copies of me. 😄 If you see an issue that looks outdated, please feel free to leave a comment.

[viniciusll]

@zwithz thank you so much