React: [website] Side nav sometimes shows an incorrect "current" highlight

Created on 27 Sep 2017 · 7Comments · Source: facebook/react

Bug:
The active navbar item is incorrect sometimes.

Reproduction steps:
Navigate to http://reactjs.netlify.com/docs/handling-events.html. Observe that Synthetic Event is highlighted.

Expected Behavior:
Quick Start > Handling Events should be highlighted.

starter Bug

Source

clemmy

Most helpful comment

Check out gatsby branch, run yarn and yarn dev in the www folder, open http://localhost:8000. Try to reproduce the issue. Then try to figure out why it breaks :-)

gaearon on 28 Sep 2017

👍2

All 7 comments

Nice catch, @clemmy

bvaughn on 27 Sep 2017

Hi @bvaughn,
I would like to tackle this issue. It would be my first time contributing to React, so I will most likely need a little direction.

NicBonetto on 28 Sep 2017

👍2

Check out gatsby branch, run yarn and yarn dev in the www folder, open http://localhost:8000. Try to reproduce the issue. Then try to figure out why it breaks :-)

gaearon on 28 Sep 2017

👍2

Hi @NicBonetto,

Sounds great! I'm sure myself, @gaearon, and @flarnie will be happy to help you if you have questions.

bvaughn on 28 Sep 2017

👍1

New PR #10951

NicBonetto on 29 Sep 2017

Is this issue being worked on by anyone? I just encountered it while following along with the documentation. I looked at the reference to PR #10951, but it looks like that PR isn't getting merged? I could try to tackle it if no one is currently working on it (Beginner here!).

robertcoopercode on 2 Oct 2017

Hey @Engineering-Robert. Thanks for asking. We've had 2 PRs submitted that fix this issue though. The 1st one just needed to be rebased before it could be merged- and it just was. 😄 There are some other [website] issues though that you might be interested in looking at!

bvaughn on 2 Oct 2017

👍1

Was this page helpful?

0 / 5 - 0 ratings