This release has been a bit rocky. 馃槢
I'm keeping track of known issues to fix them up together in the next patch.
unstable_batchedUpdates on shallow renderer (https://github.com/facebook/react/pull/9382), needed for Enzyme (https://github.com/airbnb/enzyme/pull/876#issuecomment-292747996)object-assignprocess shimlinked-inputcreate-react-class (tagging @acdlite for this and add the rest of us)Regarding create-react-class:
replaceState callback issue). Currently there are no peer deps at all, only dev deps.Packages misses dependency on
object-assign
Just the create-react-class package, right?
yep
FWIW the prop-types package.json does list "BSD-3-Clause" license which is, I think, the same as the one we have in the LICENSE files.
Going to tag @acdlite to do this too since it looks like he's made changes to prop-types that weren't pushed to 15.5-dev or 15-stable branches.
Going to tag @acdlite to do this too since it looks like he's made changes to prop-types that weren't pushed to 15.5-dev or 15-stable branches.
Did the source of truth move to reactjs/prop-types? Maybe we should delete folder in the branches.
Oh! You're right. Andrew mentioned that at one point but I forgot.
I'd add the license and patents file and do a point release of prop-types then.
I think there are a couple of additional things we need to do for create-react-class:
replaceState callback issue). Currently there are no peer deps at all.object-assign depFormerly, React.createClass would set the displayName by default. This seems to have been omitted in create-react-class. Is this intentional? Thanks.
create-react-class still does this for DEV mode, no?
// Add verbose displayName to the function, which helps when looking
// at profiling tools.
if (typeof property === 'function' && spec.displayName) {
proto[name].displayName = spec.displayName + '_' + name;
}
I think @J-Dickson is referring to Babel inferring displayName automatically (which is the case with React.createClass call). AFAIK we're waiting for a Babel release that does it for createReactClass. (@acdlite can clarify.)
But until it's not there, the codemod we're providing (see the blog post) adds a displayName manually to your existing classes.
Oh! So this: babel/babel/pull/5554
Most helpful comment
I think there are a couple of additional things we need to do for create-react-class:
replaceStatecallback issue). Currently there are no peer deps at all.object-assigndep