React: 15.4 minor wasn't supposed to break so much stuff, was it?

Created on 16 Nov 2016  路  2Comments  路  Source: facebook/react

screenshot from 2016-11-16 14-38-06

Some packages broke due to missing stuffs on react/lib/...
Seems like it shouldn't happen, even my build process broke suddenly due to react 15.4 update (react packages set to ^15.3.2)

Thanks!

Most helpful comment

Hi, thanks for the report.

If you rely on packages that rely on undocumented or private APIs, consider keeping React version pinned. It is never safe to rely on internal APIs and we never supported this officially. We can't consider private APIs as part of semver because there is no way to tell if any particular change in the internals would break a library reaching into them. This is just an unsupported way of using React.

We asked people to test 15.4 RC for a month: https://github.com/facebook/react/issues/7770#issuecomment-253899837. Unfortunately there is nothing we can do to force libraries using private APIs to stop doing this until we start using flat bundles.

Please reach out to maintainers of https://github.com/zilverline/react-tap-event-plugin and ask them to get https://github.com/zilverline/react-tap-event-plugin/pull/82 merged. But it might break later again because reaching into internal APIs is just not supported, and never has been.

All 2 comments

Hi, thanks for the report.

If you rely on packages that rely on undocumented or private APIs, consider keeping React version pinned. It is never safe to rely on internal APIs and we never supported this officially. We can't consider private APIs as part of semver because there is no way to tell if any particular change in the internals would break a library reaching into them. This is just an unsupported way of using React.

We asked people to test 15.4 RC for a month: https://github.com/facebook/react/issues/7770#issuecomment-253899837. Unfortunately there is nothing we can do to force libraries using private APIs to stop doing this until we start using flat bundles.

Please reach out to maintainers of https://github.com/zilverline/react-tap-event-plugin and ask them to get https://github.com/zilverline/react-tap-event-plugin/pull/82 merged. But it might break later again because reaching into internal APIs is just not supported, and never has been.

Same with the authors of draft-js-export-html (not a Facebook-owned module).

Was this page helpful?
0 / 5 - 0 ratings

Related issues

kib357 picture kib357  路  103Comments

sophiebits picture sophiebits  路  107Comments

gaearon picture gaearon  路  227Comments

acdlite picture acdlite  路  83Comments

gabegreenberg picture gabegreenberg  路  119Comments