React: Missing onLoad and onError events on SVG <image> tag

[tombigel]

SVG <image> is supposed as far as I know to support at least the same onload and onerror events <img> supports.

From looking at React code the events are handled on specific elements in ReactDOMComponents.js in trapBubbledEventsLocal, mountComponent, unmountComponent.

It would be easy to create a pull request to add 'image' to these cases, but it seems that there is a separation between js files that handle DOM and SVG in the codebase that this might collide with.

Am I correct and there is more to it than just adding more cases? Or these functions are the right place to also handle SVG image?

[savelichalex]

+1 to add this handler

[niwinz]

+1

[shalanah]

+1

[gaearon]

If you’re interested in this, could you please send a PR? Yes I think ReactDOMComponent.js is the right place for this.

[Flaque]

@gaearon I'm gonna try this.

[Simek]

I've commited PR which adds onLoad and onError events to SVG, but we are still missing few others like onUnload, onResize, onScroll, onZoom etc. Thank you @gaearon for mentioning correct file name.

[mdogadailo]

<image /> load and error events were fixes here #9042

[zabojad]

@mdogadailo that doesn't seem to have affected <svg /> load and error events...

[mdogadailo]

@zabojad yes, but this ticket about <image /> tag, not about <svg /> element like in #9607

[aweary]

This was resolved by https://github.com/facebook/react/pull/9042/ 🍾

[SahidH]

@aweary seems that onLoad event is not getting dispatched on IE11 (it is supported)

[gaearon]

(Let's track that in https://github.com/facebook/react/issues/11058)