React-virtualized: Replace react-addons-shallow-compare with PureComponent?
According to the docs, react-addons-shallow-compare is a legacy addon. Have you considered replacing it with React.PureComponent?
cesarandreu
All 9 comments
Doesn't seem appropriate for a lib, considering PureComponent is a recent addition and I'm trying to maintain backwards compatibility. I could make that upgrade in the next major release- but it would be backwards-breaking.
bvaughn
on 17 Nov 2016
Ah, that's totally understandable. Do you know if there's any public metrics that show each version's usage? Would it be safe to assume your plan is to follow along with react and drop v14 support when v16 is released?
cesarandreu
on 18 Nov 2016
Hm, no clue. I don't know if even the React team knows that, although I'll ask Ben when I see him.
Yes, that would be reasonable to assume. 馃槃
bvaughn
on 18 Nov 2016
Closing for now 馃槃 We can revisit when next React version drops
bvaughn
on 20 Nov 2016
@bvaughn Can we revisit this? Dropping shallow-compare would be nice because it frees up that pesky peer dependency.
dsifford
on 20 Jan 2017
We can revisit once React 16 lands _or_ with the next major react-virtualized released. 馃槃
bvaughn
on 20 Jan 2017
Sounds good! Sorry, I suppose I should have prefaced that last message with "I have no idea what version React was at when you guys first had this conversation".
* subscribes to thread *
dsifford
on 20 Jan 2017
No problem 馃槃 This ticket was from November '16 and React 15 has been out since April '16, so same major version.
bvaughn
on 20 Jan 2017
FYI thought you might like to know that the upcoming react-virtualized version 9 will drop support for shallowCompare in favor of using React.PureComponent.
bvaughn
on 13 Feb 2017
Related issues
wnz99
路
3Comments
athorwall
路
4Comments
mikedevita
路
3Comments
clauderic
路
3Comments
EdBoucher
路
3Comments
Most helpful comment
We can revisit once React 16 lands _or_ with the next major react-virtualized released. 馃槃