React-toolbox: List ListItem Ripple effect Issue

Created on 1 Feb 2017  路  3Comments  路  Source: react-toolbox/react-toolbox

The ripple effect moves outside the bounds of the element, I've copied the example straight from docs, this occurs only with List.

| Library | Version |
|:-----|:-----|
| react | 15.4.2 |
|react-toolbox |^2.0.0-beta.6 |

Image

Most helpful comment

There is a typo error, which accidently passes ripple boolean to theme, which causes the classname to be set undefined.

I don't have the setup else i would post a PR is a very simple change.

https://github.com/react-toolbox/react-toolbox/blob/dev/components/list/ListItem.js#L75

All 3 comments

Same issue here, 2.0.0-beta.6.

There is a typo error, which accidently passes ripple boolean to theme, which causes the classname to be set undefined.

I don't have the setup else i would post a PR is a very simple change.

https://github.com/react-toolbox/react-toolbox/blob/dev/components/list/ListItem.js#L75

1215

Was this page helpful?
0 / 5 - 0 ratings

Related issues

thomasthiebaud picture thomasthiebaud  路  4Comments

claudiuapetrei picture claudiuapetrei  路  4Comments

L-u-k-e picture L-u-k-e  路  3Comments

gustavohenke picture gustavohenke  路  3Comments

landabaso picture landabaso  路  4Comments