React-toolbox: Input-Component not completely conform to spec

Created on 14 Oct 2016  路  3Comments  路  Source: react-toolbox/react-toolbox

Thanks for this great work, keep it going!

Today I noticed that the input-component does not correspond exactly to the specifications of Material Design. According to https://material.google.com/components/text-fields.html#text-fields-labels input-fields with a label should have a height of 72dp in total and a padding of 16dp above the label and below the input text.
The padding-top is, indeed, only 4dp (20 of the padding - 16 of the label-font-size).

Feedback Needed Material Spec Question

Most helpful comment

I vote for following the spec. It's overridable if people want to change it.

All 3 comments

Hi @fraenku! Actually this is intentional. In my opinion that was way too much padding but if more people agree that it should be incremented I've be happy to do it :)

Well, I like it the way it is right now, but if we want to follow the spec 100% we should do it always, not in some cases only.

I vote for following the spec. It's overridable if people want to change it.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

saintc0d3r picture saintc0d3r  路  4Comments

gustavohenke picture gustavohenke  路  3Comments

delacruz-dev picture delacruz-dev  路  4Comments

wtgtybhertgeghgtwtg picture wtgtybhertgeghgtwtg  路  3Comments

mauron85 picture mauron85  路  3Comments