React-three-fiber: incorrect unsubscribe logic?

[objectisundefined]

src/canvas.js, was I missing the point?

subscribe: (fn, main) => {
   state.current.subscribers.push(fn)
   return () => (state.current.subscribers = state.current.subscribers.filter(s => s === fn))
},

[drcmda]

What's wrong with it? Looks ok to me. It adds a subscriber and returns the unsub function, which removes the callback from the list, similar to how redux subscribe() does it.

[objectisundefined]

if you want to remove the callback, you should use filter(s => s !== fn)

[drcmda]

oh! my! ... 😄 why can i never remember that!

[drcmda]

it's fixed, will make a patch later on, after some other changes i want to do today.