React-table: GlobalFilter not filtering on data subrows

[arnoBruynseels]

Describe the bug
The Global Filter does not filter on data subrows out-of-the-box.

To Reproduce
Steps to reproduce the behavior:

1. Implement Global Filtering (useGlobalFilter) with manualGlobalFilter = false (default)
2. Implement Row Expansion (useExpanded)

Expected behavior
The Global Filter, also filters on the subrows of data default out-of-the-box without any custom filtering needed.

Codesandbox!
codesandbox

Desktop:

• OS: Windows 10
• Browser: Chrome
• Version: 80.0.3987.116

[tannerlinsley]

As far as I know this is working now in your codesandbox with the latest version. Thanks

[noahbenham]

@tannerlinsley Was this behavior recently corrected? I’m seeing sub-rows failing to global filter using rc16, agnostic of the useExpanded plugin.

[tannerlinsley]

To my knowledge yes. But it could be a regression we haven’t tested for.
On Mar 6, 2020, 5:19 PM -0700, Noah Benham [e-mail], wrote:

@tannerlinsley Was this behavior recently corrected? I’m seeing sub-rows failing to global filter using rc16, agnostic of the useExpanded plugin.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

[arnoBruynseels]

@tannerlinsley I'm not seeing this working in my codesandbox.

Steps to reproduce:

1. Expand a row
2. Type in the global filter the value of some column of the expanded row
3. No results are found

[uqix]

@arnoBruynseels useFilters and useGlobalFilter only filter subRows of rows which match the filter first, you can flatten rows to avoid this, FYI , I wrote a filter wrapper

[arnoBruynseels]

@uqix Would you be so kind to provide a codesandbox example?

Nevermind, I see how it works now, thanks for the information!

[lajerca]

@tannerlinsley Any update on this? Not working as far as I can see (with latest version) in the provided sandbox. @uqix is right, the filter works only if parent rows match too. If the solution is using flatRows with manual global filter, a CodeSandbox would be cool!