React-styleguidist: Using devtools with react-stylegudist

[benedyktdryl]

Hi,

I know that devtools are ignored along with some other configuration keys.

My question is:

• Is there any particular reason for that? Is it breaking react-stylegudist entirely or there are some edge cases?
• Can we disable ignoring somehow or you will consider PR with disabling it optionally feature?
• Is there kind of recipe for having sourcemaps on development when using your library?

Thanks for your time!

[sapegin]

For devtools it should not be necessary, so feel free to send a pull request ;-)

The only thing I’m not sure about is the production build: should we disable sourcemaps in this case?

[benedyktdryl]

So I should go with optional disabling ignoring or I can just remove devtools from ignored keys list?

[sapegin]

@n1313 Did you want to be able to change devtools? What should we do for production build?

[n1313]

Hmmm, no, I don't think devtools matters for what I do.

Sent from my iPhone

On 30 May 2017, at 19:12, Artem Sapegin [e-mail] wrote:

@n1313 Did you want to be able to change devtools? What should we do for production build?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[sapegin]

@n1313 Sorry, it was @cef62 ;-)

[n1313]

Yeah, typical... "People with numbers in their nicknames, they're all the same" :(((

Sent from my iPhone

On 30 May 2017, at 19:22, Artem Sapegin [e-mail] wrote:

@n1313 Sorry, it was @cef62 ;-)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[benedyktdryl]

Any updates on that?

CC: @cef62 @sapegin

[sapegin]

I think it should explicitly disable devtool in production, otherwise it would complicate style guide configuration and will be easy to miss.